From c159ed11330c57c43b853855b227761dbb904dd4 Mon Sep 17 00:00:00 2001 From: Alexey Volkov Date: Wed, 17 Jul 2019 17:10:52 -0700 Subject: [PATCH 1/4] SDK - Stop compressing the artifacts DIsabled compressing artifacts to .tar.gz archives. Fixes https://github.com/kubeflow/pipelines/issues/1383 --- sdk/python/kfp/compiler/_op_to_template.py | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk/python/kfp/compiler/_op_to_template.py b/sdk/python/kfp/compiler/_op_to_template.py index 564529774cd..1512a12d2f8 100644 --- a/sdk/python/kfp/compiler/_op_to_template.py +++ b/sdk/python/kfp/compiler/_op_to_template.py @@ -182,6 +182,7 @@ def _op_to_template(op: BaseOp): op.artifact_location, name=name, path=path, + archive='none', key='runs/{{workflow.uid}}/{{pod.name}}/' + name + '.tgz')) for name, path in output_artifact_paths.items() ] From 738a89613f8ce3e4fa99d583f612b37382c84f30 Mon Sep 17 00:00:00 2001 From: Alexey Volkov Date: Wed, 17 Jul 2019 18:42:30 -0700 Subject: [PATCH 2/4] Setting the archive strategy in the backend. --- backend/src/apiserver/resource/resource_manager.go | 1 + 1 file changed, 1 insertion(+) diff --git a/backend/src/apiserver/resource/resource_manager.go b/backend/src/apiserver/resource/resource_manager.go index b12f2f1a6d9..7f7e6b8f103 100644 --- a/backend/src/apiserver/resource/resource_manager.go +++ b/backend/src/apiserver/resource/resource_manager.go @@ -219,6 +219,7 @@ func (r *ResourceManager) CreateRun(apiRun *api.Run) (*model.RunDetail, error) { if artifact.Name == "mlpipeline-ui-metadata" || artifact.Name == "mlpipeline-metrics" { workflow.Workflow.Spec.Templates[templateIdx].Outputs.Artifacts[artIdx].Optional = true } + artifact.Archive = &workflowapi.ArchiveStrategy{None: &workflowapi.NoneStrategy{}} } } From b83e4cb410bb4eedf2a89891a498e25e80714d19 Mon Sep 17 00:00:00 2001 From: Alexey Volkov Date: Fri, 19 Jul 2019 12:14:26 -0700 Subject: [PATCH 3/4] Remove compression option in SDK --- sdk/python/kfp/compiler/_op_to_template.py | 1 - 1 file changed, 1 deletion(-) diff --git a/sdk/python/kfp/compiler/_op_to_template.py b/sdk/python/kfp/compiler/_op_to_template.py index 1512a12d2f8..564529774cd 100644 --- a/sdk/python/kfp/compiler/_op_to_template.py +++ b/sdk/python/kfp/compiler/_op_to_template.py @@ -182,7 +182,6 @@ def _op_to_template(op: BaseOp): op.artifact_location, name=name, path=path, - archive='none', key='runs/{{workflow.uid}}/{{pod.name}}/' + name + '.tgz')) for name, path in output_artifact_paths.items() ] From 8fc79009230062222f9cdcea6722db9f844d6b6d Mon Sep 17 00:00:00 2001 From: Alexey Volkov Date: Thu, 26 Sep 2019 00:05:55 -0700 Subject: [PATCH 4/4] Leave the mlmetadata- artifacts compressed for now --- backend/src/apiserver/resource/resource_manager.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backend/src/apiserver/resource/resource_manager.go b/backend/src/apiserver/resource/resource_manager.go index 7f7e6b8f103..c9a4c8efc02 100644 --- a/backend/src/apiserver/resource/resource_manager.go +++ b/backend/src/apiserver/resource/resource_manager.go @@ -218,8 +218,9 @@ func (r *ResourceManager) CreateRun(apiRun *api.Run) (*model.RunDetail, error) { for artIdx, artifact := range template.Outputs.Artifacts { if artifact.Name == "mlpipeline-ui-metadata" || artifact.Name == "mlpipeline-metrics" { workflow.Workflow.Spec.Templates[templateIdx].Outputs.Artifacts[artIdx].Optional = true + } else { + artifact.Archive = &workflowapi.ArchiveStrategy{None: &workflowapi.NoneStrategy{}} } - artifact.Archive = &workflowapi.ArchiveStrategy{None: &workflowapi.NoneStrategy{}} } }