Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline parameters should be accessible to pipeline logic #1099

Closed
JavaDerek opened this issue Apr 6, 2019 · 3 comments
Closed

Pipeline parameters should be accessible to pipeline logic #1099

JavaDerek opened this issue Apr 6, 2019 · 3 comments
Assignees
Labels

Comments

@JavaDerek
Copy link

If you pass a parameter into your pipeline from the UI now, the only thing you can do with it is to pass it as a startup argument to a Docker container. This prevents them from being used to control execution flow, which is a very likely use case. For example, if I have a pipeline that downloads data, scrubs it, use it in training and then publishes a model, I'm very likely to want to repeat the training and publishing multiple times without wanting to repeat the initial download and scrub. If the pipeline logic could access the parameters, one could pass in a "starting step" parameter for runs to tell them not to bother re-downloading or re-scrubbing data that has already been downloaded, scrubbed and stored.

If it isn't possible (or advisable) to change the pipeline parameters to make them accessible from the actual pipeline logic, then can we at least have a standard Docker image that reads in arguments in key/value format (e.g. "name1=value1 name2=value2") and drops all the values into output parameters with the requested names? Then people could run that as the first step in their pipelines, passing in the pipeline parameters and accessing them as output variables from that step for the rest of the pipeline.

@JavaDerek
Copy link
Author

Of course, it turns out that the output parameters are exactly the same as the input parameters, so the Docker image approach won't work. There should be some way for the user running the pipeline to pass data into the pipeline at runtime that can be used by the pipeline's Python.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 9, 2019

What you probably really want is a fix for the bug that prevents pipeline parameters to be used in dsl.Conditional (#827). Is that correct?

@Ark-kun Ark-kun self-assigned this Apr 9, 2019
@vicaire
Copy link
Contributor

vicaire commented Apr 11, 2019

Resolving in favor of #827. Please re-open if this is a different issue.

@vicaire vicaire closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants