Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samples should load explicit versions of component definitions. #1098

Closed
Ark-kun opened this issue Apr 6, 2019 · 2 comments
Closed

Samples should load explicit versions of component definitions. #1098

Ark-kun opened this issue Apr 6, 2019 · 2 comments
Assignees
@Ark-kun
Labels
area/components area/samples kind/bug priority/p1

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 6, 2019

Currently, samples load components from master.
@Ark-kun Ark-kun self-assigned this Apr 6, 2019
@jessiezcc
Copy link
Contributor

@Ark-kun, can you explain why this is P0?
/cc @gaoning777

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 25, 2019 •
edited
Loading

This was P0, because the issue was bound to cause forward compatibility issues (old pipeline version using latest component versions). Fortunately, this issue has been fixed long time ago and sample pipelines pin component versions. Final fix in #1176

@Ark-kun Ark-kun closed this as completed Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
area/components area/samples kind/bug priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ark-kun @vicaire @jessiezcc