Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fail the e2e tests if the image builds fail #10929

Closed
HumairAK opened this issue Jun 20, 2024 · 5 comments · Fixed by #11115
Closed

[CI] Fail the e2e tests if the image builds fail #10929

HumairAK opened this issue Jun 20, 2024 · 5 comments · Fixed by #11115
Assignees

Comments

@HumairAK
Copy link
Collaborator

HumairAK commented Jun 20, 2024

If the image builds fail, the e2e tests will proceed as usual, but fail to deploy with "imagePullBackOff" states for the associated deployments.

Relevant gh workflows:

@HumairAK
Copy link
Collaborator Author

Example: https://github.com/kubeflow/pipelines/actions/runs/9599914548/job/26474847944?pr=10787

We could have notified a lot earlier for this failure

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Aug 20, 2024
@ElayAharoni
Copy link
Contributor

/assign

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Aug 21, 2024
@ElayAharoni
Copy link
Contributor

i think this issue is fixed by this pr #11115
i created and was merged yesterday

@HumairAK
Copy link
Collaborator Author

thanks @ElayAharoni !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants