From ab05dd7f27b375ceba21f12112ef09363bd082a0 Mon Sep 17 00:00:00 2001 From: Nikolaos Loukas Date: Wed, 29 Jun 2022 16:57:54 +0300 Subject: [PATCH 1/7] Add GH action for testing JWA manifests. --- .github/workflows/jwa_kind_test.yaml | 34 +++++++++++++++++++ common/testing/gh-actions/install_kind.sh | 10 ++++++ .../testing/gh-actions/install_kustomize.sh | 5 +++ common/testing/gh-actions/kind-1-22.yaml | 24 +++++++++++++ 4 files changed, 73 insertions(+) create mode 100644 .github/workflows/jwa_kind_test.yaml create mode 100644 common/testing/gh-actions/install_kind.sh create mode 100644 common/testing/gh-actions/install_kustomize.sh create mode 100644 common/testing/gh-actions/kind-1-22.yaml diff --git a/.github/workflows/jwa_kind_test.yaml b/.github/workflows/jwa_kind_test.yaml new file mode 100644 index 0000000000..0267a10553 --- /dev/null +++ b/.github/workflows/jwa_kind_test.yaml @@ -0,0 +1,34 @@ +name: Build & Apply JWA manifests in KinD +on: + pull_request: + paths: + - apps/jupyter/jupyter-web-app/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/jupyter/jupyter-web-app/upstream + kubectl create ns kubeflow + kustomize build overlays/istio | kubectl apply -f - \ No newline at end of file diff --git a/common/testing/gh-actions/install_kind.sh b/common/testing/gh-actions/install_kind.sh new file mode 100644 index 0000000000..2c7f9eedcc --- /dev/null +++ b/common/testing/gh-actions/install_kind.sh @@ -0,0 +1,10 @@ +#!/bin/bash +set -e +echo "Fetching KinD executable ..." +sudo swapoff -a +sudo rm -f /swapfile +sudo mkdir -p /tmp/etcd +sudo mount -t tmpfs tmpfs /tmp/etcd +curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.14.0/kind-linux-amd64 +chmod +x ./kind +sudo mv kind /usr/local/bin \ No newline at end of file diff --git a/common/testing/gh-actions/install_kustomize.sh b/common/testing/gh-actions/install_kustomize.sh new file mode 100644 index 0000000000..45196faf60 --- /dev/null +++ b/common/testing/gh-actions/install_kustomize.sh @@ -0,0 +1,5 @@ +#!/bin/bash +set -e +curl --silent --location --remote-name "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize/v3.2.3/kustomize_kustomize.v3.2.3_linux_amd64" +chmod a+x kustomize_kustomize.v3.2.3_linux_amd64 +sudo mv kustomize_kustomize.v3.2.3_linux_amd64 /usr/local/bin/kustomize \ No newline at end of file diff --git a/common/testing/gh-actions/kind-1-22.yaml b/common/testing/gh-actions/kind-1-22.yaml new file mode 100644 index 0000000000..bd4eaa69aa --- /dev/null +++ b/common/testing/gh-actions/kind-1-22.yaml @@ -0,0 +1,24 @@ +apiVersion: kind.x-k8s.io/v1alpha4 +kind: Cluster +# Configure registry for KinD. +containerdConfigPatches: +- |- + [plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"] + endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"] +# This is needed in order to support projected volumes with service account tokens. +# See: https://kubernetes.slack.com/archives/CEKK1KTN2/p1600268272383600 +kubeadmConfigPatches: + - | + apiVersion: kubeadm.k8s.io/v1beta2 + kind: ClusterConfiguration + metadata: + name: config + apiServer: + extraArgs: + "service-account-issuer": "kubernetes.default.svc" + "service-account-signing-key-file": "/etc/kubernetes/pki/sa.key" +nodes: +- role: control-plane + image: kindest/node:1.22.9@sha256:ad5b8404c4052781365a4e70bb7d17c5331e4177bd4a7cd214339316cd6193b6 +- role: worker + image: kindest/node:1.22.9@sha256:ad5b8404c4052781365a4e70bb7d17c5331e4177bd4a7cd214339316cd6193b6 From a4386c6fe2ec7aa9bf15672e5528254b3357b6fc Mon Sep 17 00:00:00 2001 From: Nikolaos Loukas Date: Wed, 29 Jun 2022 17:05:19 +0300 Subject: [PATCH 2/7] Update permissions. --- {common/testing => testing}/gh-actions/install_kind.sh | 0 {common/testing => testing}/gh-actions/install_kustomize.sh | 0 {common/testing => testing}/gh-actions/kind-1-22.yaml | 0 3 files changed, 0 insertions(+), 0 deletions(-) rename {common/testing => testing}/gh-actions/install_kind.sh (100%) mode change 100644 => 100755 rename {common/testing => testing}/gh-actions/install_kustomize.sh (100%) mode change 100644 => 100755 rename {common/testing => testing}/gh-actions/kind-1-22.yaml (100%) diff --git a/common/testing/gh-actions/install_kind.sh b/testing/gh-actions/install_kind.sh old mode 100644 new mode 100755 similarity index 100% rename from common/testing/gh-actions/install_kind.sh rename to testing/gh-actions/install_kind.sh diff --git a/common/testing/gh-actions/install_kustomize.sh b/testing/gh-actions/install_kustomize.sh old mode 100644 new mode 100755 similarity index 100% rename from common/testing/gh-actions/install_kustomize.sh rename to testing/gh-actions/install_kustomize.sh diff --git a/common/testing/gh-actions/kind-1-22.yaml b/testing/gh-actions/kind-1-22.yaml similarity index 100% rename from common/testing/gh-actions/kind-1-22.yaml rename to testing/gh-actions/kind-1-22.yaml From 51fc3d28fde9d82eb7b92caa35ebdc9eed68d7e0 Mon Sep 17 00:00:00 2001 From: Nikolaos Loukas Date: Wed, 29 Jun 2022 17:16:13 +0300 Subject: [PATCH 3/7] Add GH actions for PodDefaults. --- .github/workflows/poddefaults_kind_test.yaml | 43 ++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 .github/workflows/poddefaults_kind_test.yaml diff --git a/.github/workflows/poddefaults_kind_test.yaml b/.github/workflows/poddefaults_kind_test.yaml new file mode 100644 index 0000000000..db4bc4bb00 --- /dev/null +++ b/.github/workflows/poddefaults_kind_test.yaml @@ -0,0 +1,43 @@ +name: Build & Apply PodDefaults manifests in KinD +on: + pull_request: + paths: + - apps/admission-webhook/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./components/testing/gh-actions/install_kind.sh + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Install cert-manager + run: | + cd common/cert-manager + kustomize build cert-manager/base | kubectl apply -f - + kustomize build kubeflow-issuer/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/admission-webhook/upstream + kubectl create ns kubeflow + kustomize build overlays/cert-manager | kubectl apply -f - \ No newline at end of file From 0938f6fab5f72ead486331b5c610399ff30c65b1 Mon Sep 17 00:00:00 2001 From: Nikolaos Loukas Date: Wed, 29 Jun 2022 17:18:22 +0300 Subject: [PATCH 4/7] Add GH actions for PodDefaults fix typo. --- .github/workflows/poddefaults_kind_test.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/poddefaults_kind_test.yaml b/.github/workflows/poddefaults_kind_test.yaml index db4bc4bb00..bdbbc2e898 100644 --- a/.github/workflows/poddefaults_kind_test.yaml +++ b/.github/workflows/poddefaults_kind_test.yaml @@ -11,9 +11,6 @@ jobs: - name: Checkout uses: actions/checkout@v3 - - name: Install KinD - run: ./components/testing/gh-actions/install_kind.sh - - name: Install KinD run: ./testing/gh-actions/install_kind.sh From 43662804424c3e5124fb0de9172142eb9bdabcd0 Mon Sep 17 00:00:00 2001 From: Nikolaos Loukas Date: Wed, 29 Jun 2022 18:59:31 +0300 Subject: [PATCH 5/7] Add GH actions for applying manifests in KinD for each component. --- .github/workflows/centraldb_kind_test.yaml | 34 ++++++++++++++++ .github/workflows/jwa_kind_test.yaml | 2 +- .github/workflows/katib_kind_test.yaml | 40 +++++++++++++++++++ .github/workflows/kserve_kind_test.yaml | 35 ++++++++++++++++ .../workflows/nb_controller_kind_test.yaml | 34 ++++++++++++++++ .github/workflows/pipeline_kind_test.yaml | 40 +++++++++++++++++++ .github/workflows/poddefaults_kind_test.yaml | 5 ++- .github/workflows/profiles_kind_test.yaml | 34 ++++++++++++++++ .../workflows/tb_controller_kind_test.yaml | 34 ++++++++++++++++ .../workflows/train_operator_kind_test.yaml | 34 ++++++++++++++++ .github/workflows/twa_kind_test.yaml | 34 ++++++++++++++++ .github/workflows/vwa_kind_test.yaml | 34 ++++++++++++++++ 12 files changed, 358 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/centraldb_kind_test.yaml create mode 100644 .github/workflows/katib_kind_test.yaml create mode 100644 .github/workflows/kserve_kind_test.yaml create mode 100644 .github/workflows/nb_controller_kind_test.yaml create mode 100644 .github/workflows/pipeline_kind_test.yaml create mode 100644 .github/workflows/profiles_kind_test.yaml create mode 100644 .github/workflows/tb_controller_kind_test.yaml create mode 100644 .github/workflows/train_operator_kind_test.yaml create mode 100644 .github/workflows/twa_kind_test.yaml create mode 100644 .github/workflows/vwa_kind_test.yaml diff --git a/.github/workflows/centraldb_kind_test.yaml b/.github/workflows/centraldb_kind_test.yaml new file mode 100644 index 0000000000..19b10e0b28 --- /dev/null +++ b/.github/workflows/centraldb_kind_test.yaml @@ -0,0 +1,34 @@ +name: Build & Apply CentralDashboard manifests in KinD +on: + pull_request: + paths: + - apps/centraldashboard/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/centraldashboard/upstream + kubectl create ns kubeflow + kustomize build overlays/kserve | kubectl apply -f - diff --git a/.github/workflows/jwa_kind_test.yaml b/.github/workflows/jwa_kind_test.yaml index 0267a10553..f5e4998436 100644 --- a/.github/workflows/jwa_kind_test.yaml +++ b/.github/workflows/jwa_kind_test.yaml @@ -31,4 +31,4 @@ jobs: run: | cd apps/jupyter/jupyter-web-app/upstream kubectl create ns kubeflow - kustomize build overlays/istio | kubectl apply -f - \ No newline at end of file + kustomize build overlays/istio | kubectl apply -f - diff --git a/.github/workflows/katib_kind_test.yaml b/.github/workflows/katib_kind_test.yaml new file mode 100644 index 0000000000..9013438a31 --- /dev/null +++ b/.github/workflows/katib_kind_test.yaml @@ -0,0 +1,40 @@ +name: Build & Apply Katib manifests in KinD +on: + pull_request: + paths: + - apps/katib/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Install cert-manager + run: | + cd common/cert-manager + kustomize build cert-manager/base | kubectl apply -f - + kustomize build kubeflow-issuer/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/katib/upstream + kubectl create ns kubeflow + kustomize build installs/katib-with-kubeflow | kubectl apply -f - diff --git a/.github/workflows/kserve_kind_test.yaml b/.github/workflows/kserve_kind_test.yaml new file mode 100644 index 0000000000..f5345070f8 --- /dev/null +++ b/.github/workflows/kserve_kind_test.yaml @@ -0,0 +1,35 @@ +name: Build & Apply KServe manifests in KinD +on: + pull_request: + paths: + - contrib/kserve/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd contrib/kserve + kubectl create ns kubeflow + kustomize build kserve | kubectl apply -f - + kustomize build models-web-app/overlays/kubeflow | kubectl apply -f - diff --git a/.github/workflows/nb_controller_kind_test.yaml b/.github/workflows/nb_controller_kind_test.yaml new file mode 100644 index 0000000000..d7d4c5e887 --- /dev/null +++ b/.github/workflows/nb_controller_kind_test.yaml @@ -0,0 +1,34 @@ +name: Build & Apply Notebook Controller manifests in KinD +on: + pull_request: + paths: + - apps/jupyter/notebook-controller/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/jupyter/notebook-controller/upstream + kubectl create ns kubeflow + kustomize build overlays/kubeflow | kubectl apply -f - diff --git a/.github/workflows/pipeline_kind_test.yaml b/.github/workflows/pipeline_kind_test.yaml new file mode 100644 index 0000000000..d011af00f0 --- /dev/null +++ b/.github/workflows/pipeline_kind_test.yaml @@ -0,0 +1,40 @@ +name: Build & Apply Kubeflow Pipelines manifests in KinD +on: + pull_request: + paths: + - apps/pipeline/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Install cert-manager + run: | + cd common/cert-manager + kustomize build cert-manager/base | kubectl apply -f - + kustomize build kubeflow-issuer/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/pipeline/upstream + kubectl create ns kubeflow + kustomize build env/cert-manager/platform-agnostic-multi-user | kubectl apply -f - diff --git a/.github/workflows/poddefaults_kind_test.yaml b/.github/workflows/poddefaults_kind_test.yaml index bdbbc2e898..01c5ffefe8 100644 --- a/.github/workflows/poddefaults_kind_test.yaml +++ b/.github/workflows/poddefaults_kind_test.yaml @@ -30,11 +30,14 @@ jobs: - name: Install cert-manager run: | cd common/cert-manager + kubectl create namespace cert-manager kustomize build cert-manager/base | kubectl apply -f - + echo "Waiting for cert-manager to be ready ..." + kubectl wait --for=condition=ready pod -l 'app in (cert-manager,webhook)' --timeout=180s -n cert-manager kustomize build kubeflow-issuer/base | kubectl apply -f - - name: Build & Apply manifests run: | cd apps/admission-webhook/upstream kubectl create ns kubeflow - kustomize build overlays/cert-manager | kubectl apply -f - \ No newline at end of file + kustomize build overlays/cert-manager | kubectl apply -f - diff --git a/.github/workflows/profiles_kind_test.yaml b/.github/workflows/profiles_kind_test.yaml new file mode 100644 index 0000000000..a64533acfa --- /dev/null +++ b/.github/workflows/profiles_kind_test.yaml @@ -0,0 +1,34 @@ +name: Build & Apply Profiles manifests in KinD +on: + pull_request: + paths: + - apps/profiles/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/profiles/upstream + kubectl create ns kubeflow + kustomize build overlays/kubeflow | kubectl apply -f - diff --git a/.github/workflows/tb_controller_kind_test.yaml b/.github/workflows/tb_controller_kind_test.yaml new file mode 100644 index 0000000000..95d131bcad --- /dev/null +++ b/.github/workflows/tb_controller_kind_test.yaml @@ -0,0 +1,34 @@ +name: Build & Apply Tensorboard Controller manifests in KinD +on: + pull_request: + paths: + - apps/tensorboard/tensorboard-controller/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/tensorboard/tensorboard-controller/upstream + kubectl create ns kubeflow + kustomize build overlays/kubeflow | kubectl apply -f - diff --git a/.github/workflows/train_operator_kind_test.yaml b/.github/workflows/train_operator_kind_test.yaml new file mode 100644 index 0000000000..9b77c4d91c --- /dev/null +++ b/.github/workflows/train_operator_kind_test.yaml @@ -0,0 +1,34 @@ +name: Build & Apply Training Operator manifests in KinD +on: + pull_request: + paths: + - apps/training-operator/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/training-operator/upstream + kubectl create ns kubeflow + kustomize build overlays/kubeflow | kubectl apply -f - diff --git a/.github/workflows/twa_kind_test.yaml b/.github/workflows/twa_kind_test.yaml new file mode 100644 index 0000000000..b211f476db --- /dev/null +++ b/.github/workflows/twa_kind_test.yaml @@ -0,0 +1,34 @@ +name: Build & Apply TWA manifests in KinD +on: + pull_request: + paths: + - apps/tensorboard/tensorboards-web-app/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/tensorboard/tensorboards-web-app/upstream + kubectl create ns kubeflow + kustomize build overlays/istio | kubectl apply -f - diff --git a/.github/workflows/vwa_kind_test.yaml b/.github/workflows/vwa_kind_test.yaml new file mode 100644 index 0000000000..b87ac04d2b --- /dev/null +++ b/.github/workflows/vwa_kind_test.yaml @@ -0,0 +1,34 @@ +name: Build & Apply VWA manifests in KinD +on: + pull_request: + paths: + - apps/volumes-web-app/upstream/** + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Install KinD + run: ./testing/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config testing/gh-actions/kind-1-22.yaml + + - name: Install kustomize + run: ./testing/gh-actions/install_kustomize.sh + + - name: Install Istio + run: | + cd common/istio-1-11 + kustomize build istio-crds/base | kubectl apply -f - + kustomize build istio-namespace/base | kubectl apply -f - + kustomize build istio-install/base | kubectl apply -f - + + - name: Build & Apply manifests + run: | + cd apps/volumes-web-app/upstream + kubectl create ns kubeflow + kustomize build overlays/istio | kubectl apply -f - From 213dbf24ac64a67015071135678d5108ff1646a3 Mon Sep 17 00:00:00 2001 From: Nikolaos Loukas Date: Wed, 29 Jun 2022 20:33:37 +0300 Subject: [PATCH 6/7] Fix cert manager installation in all Actions. --- .github/workflows/katib_kind_test.yaml | 3 +++ .github/workflows/kserve_kind_test.yaml | 9 +++++++++ .github/workflows/pipeline_kind_test.yaml | 3 +++ 3 files changed, 15 insertions(+) diff --git a/.github/workflows/katib_kind_test.yaml b/.github/workflows/katib_kind_test.yaml index 9013438a31..5823610135 100644 --- a/.github/workflows/katib_kind_test.yaml +++ b/.github/workflows/katib_kind_test.yaml @@ -30,7 +30,10 @@ jobs: - name: Install cert-manager run: | cd common/cert-manager + kubectl create namespace cert-manager kustomize build cert-manager/base | kubectl apply -f - + echo "Waiting for cert-manager to be ready ..." + kubectl wait --for=condition=ready pod -l 'app in (cert-manager,webhook)' --timeout=180s -n cert-manager kustomize build kubeflow-issuer/base | kubectl apply -f - - name: Build & Apply manifests diff --git a/.github/workflows/kserve_kind_test.yaml b/.github/workflows/kserve_kind_test.yaml index f5345070f8..a8589e9ae1 100644 --- a/.github/workflows/kserve_kind_test.yaml +++ b/.github/workflows/kserve_kind_test.yaml @@ -27,6 +27,15 @@ jobs: kustomize build istio-namespace/base | kubectl apply -f - kustomize build istio-install/base | kubectl apply -f - + - name: Install cert-manager + run: | + cd common/cert-manager + kubectl create namespace cert-manager + kustomize build cert-manager/base | kubectl apply -f - + echo "Waiting for cert-manager to be ready ..." + kubectl wait --for=condition=ready pod -l 'app in (cert-manager,webhook)' --timeout=180s -n cert-manager + kustomize build kubeflow-issuer/base | kubectl apply -f - + - name: Build & Apply manifests run: | cd contrib/kserve diff --git a/.github/workflows/pipeline_kind_test.yaml b/.github/workflows/pipeline_kind_test.yaml index d011af00f0..9fd88fe470 100644 --- a/.github/workflows/pipeline_kind_test.yaml +++ b/.github/workflows/pipeline_kind_test.yaml @@ -30,7 +30,10 @@ jobs: - name: Install cert-manager run: | cd common/cert-manager + kubectl create namespace cert-manager kustomize build cert-manager/base | kubectl apply -f - + echo "Waiting for cert-manager to be ready ..." + kubectl wait --for=condition=ready pod -l 'app in (cert-manager,webhook)' --timeout=180s -n cert-manager kustomize build kubeflow-issuer/base | kubectl apply -f - - name: Build & Apply manifests From 5fbd74c0489083920cf83f1693a7dc1d7f2191d8 Mon Sep 17 00:00:00 2001 From: Nikolaos Loukas Date: Thu, 30 Jun 2022 16:37:28 +0300 Subject: [PATCH 7/7] Address review comments for all GH actions. --- .github/workflows/centraldb_kind_test.yaml | 7 ++----- .github/workflows/jwa_kind_test.yaml | 7 ++----- .github/workflows/katib_kind_test.yaml | 15 +++------------ .github/workflows/kserve_kind_test.yaml | 15 +++------------ .github/workflows/nb_controller_kind_test.yaml | 7 ++----- .github/workflows/pipeline_kind_test.yaml | 15 +++------------ .github/workflows/poddefaults_kind_test.yaml | 15 +++------------ .github/workflows/profiles_kind_test.yaml | 7 ++----- .github/workflows/tb_controller_kind_test.yaml | 7 ++----- .github/workflows/train_operator_kind_test.yaml | 7 ++----- .github/workflows/twa_kind_test.yaml | 7 ++----- .github/workflows/vwa_kind_test.yaml | 7 ++----- testing/gh-actions/install_cert_manager.sh | 9 +++++++++ testing/gh-actions/install_istio.sh | 7 +++++++ 14 files changed, 44 insertions(+), 88 deletions(-) create mode 100755 testing/gh-actions/install_cert_manager.sh create mode 100755 testing/gh-actions/install_istio.sh diff --git a/.github/workflows/centraldb_kind_test.yaml b/.github/workflows/centraldb_kind_test.yaml index 19b10e0b28..739c5d6d23 100644 --- a/.github/workflows/centraldb_kind_test.yaml +++ b/.github/workflows/centraldb_kind_test.yaml @@ -21,14 +21,11 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Build & Apply manifests run: | cd apps/centraldashboard/upstream kubectl create ns kubeflow kustomize build overlays/kserve | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/jwa_kind_test.yaml b/.github/workflows/jwa_kind_test.yaml index f5e4998436..8c8d3ceb8e 100644 --- a/.github/workflows/jwa_kind_test.yaml +++ b/.github/workflows/jwa_kind_test.yaml @@ -21,14 +21,11 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Build & Apply manifests run: | cd apps/jupyter/jupyter-web-app/upstream kubectl create ns kubeflow kustomize build overlays/istio | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/katib_kind_test.yaml b/.github/workflows/katib_kind_test.yaml index 5823610135..e67e3592fe 100644 --- a/.github/workflows/katib_kind_test.yaml +++ b/.github/workflows/katib_kind_test.yaml @@ -21,23 +21,14 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Install cert-manager - run: | - cd common/cert-manager - kubectl create namespace cert-manager - kustomize build cert-manager/base | kubectl apply -f - - echo "Waiting for cert-manager to be ready ..." - kubectl wait --for=condition=ready pod -l 'app in (cert-manager,webhook)' --timeout=180s -n cert-manager - kustomize build kubeflow-issuer/base | kubectl apply -f - + run: ./testing/gh-actions/install_cert_manager.sh - name: Build & Apply manifests run: | cd apps/katib/upstream kubectl create ns kubeflow kustomize build installs/katib-with-kubeflow | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/kserve_kind_test.yaml b/.github/workflows/kserve_kind_test.yaml index a8589e9ae1..d778dd19b7 100644 --- a/.github/workflows/kserve_kind_test.yaml +++ b/.github/workflows/kserve_kind_test.yaml @@ -21,20 +21,10 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Install cert-manager - run: | - cd common/cert-manager - kubectl create namespace cert-manager - kustomize build cert-manager/base | kubectl apply -f - - echo "Waiting for cert-manager to be ready ..." - kubectl wait --for=condition=ready pod -l 'app in (cert-manager,webhook)' --timeout=180s -n cert-manager - kustomize build kubeflow-issuer/base | kubectl apply -f - + run: ./testing/gh-actions/install_cert_manager.sh - name: Build & Apply manifests run: | @@ -42,3 +32,4 @@ jobs: kubectl create ns kubeflow kustomize build kserve | kubectl apply -f - kustomize build models-web-app/overlays/kubeflow | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/nb_controller_kind_test.yaml b/.github/workflows/nb_controller_kind_test.yaml index d7d4c5e887..007de0a56b 100644 --- a/.github/workflows/nb_controller_kind_test.yaml +++ b/.github/workflows/nb_controller_kind_test.yaml @@ -21,14 +21,11 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Build & Apply manifests run: | cd apps/jupyter/notebook-controller/upstream kubectl create ns kubeflow kustomize build overlays/kubeflow | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/pipeline_kind_test.yaml b/.github/workflows/pipeline_kind_test.yaml index 9fd88fe470..d6ad29e8b8 100644 --- a/.github/workflows/pipeline_kind_test.yaml +++ b/.github/workflows/pipeline_kind_test.yaml @@ -21,23 +21,14 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Install cert-manager - run: | - cd common/cert-manager - kubectl create namespace cert-manager - kustomize build cert-manager/base | kubectl apply -f - - echo "Waiting for cert-manager to be ready ..." - kubectl wait --for=condition=ready pod -l 'app in (cert-manager,webhook)' --timeout=180s -n cert-manager - kustomize build kubeflow-issuer/base | kubectl apply -f - + run: ./testing/gh-actions/install_cert_manager.sh - name: Build & Apply manifests run: | cd apps/pipeline/upstream kubectl create ns kubeflow kustomize build env/cert-manager/platform-agnostic-multi-user | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/poddefaults_kind_test.yaml b/.github/workflows/poddefaults_kind_test.yaml index 01c5ffefe8..fa99e1f32f 100644 --- a/.github/workflows/poddefaults_kind_test.yaml +++ b/.github/workflows/poddefaults_kind_test.yaml @@ -21,23 +21,14 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Install cert-manager - run: | - cd common/cert-manager - kubectl create namespace cert-manager - kustomize build cert-manager/base | kubectl apply -f - - echo "Waiting for cert-manager to be ready ..." - kubectl wait --for=condition=ready pod -l 'app in (cert-manager,webhook)' --timeout=180s -n cert-manager - kustomize build kubeflow-issuer/base | kubectl apply -f - + run: ./testing/gh-actions/install_cert_manager.sh - name: Build & Apply manifests run: | cd apps/admission-webhook/upstream kubectl create ns kubeflow kustomize build overlays/cert-manager | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/profiles_kind_test.yaml b/.github/workflows/profiles_kind_test.yaml index a64533acfa..fb07207b94 100644 --- a/.github/workflows/profiles_kind_test.yaml +++ b/.github/workflows/profiles_kind_test.yaml @@ -21,14 +21,11 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Build & Apply manifests run: | cd apps/profiles/upstream kubectl create ns kubeflow kustomize build overlays/kubeflow | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/tb_controller_kind_test.yaml b/.github/workflows/tb_controller_kind_test.yaml index 95d131bcad..8ab37301c6 100644 --- a/.github/workflows/tb_controller_kind_test.yaml +++ b/.github/workflows/tb_controller_kind_test.yaml @@ -21,14 +21,11 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Build & Apply manifests run: | cd apps/tensorboard/tensorboard-controller/upstream kubectl create ns kubeflow kustomize build overlays/kubeflow | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/train_operator_kind_test.yaml b/.github/workflows/train_operator_kind_test.yaml index 9b77c4d91c..4dbaa6e181 100644 --- a/.github/workflows/train_operator_kind_test.yaml +++ b/.github/workflows/train_operator_kind_test.yaml @@ -21,14 +21,11 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Build & Apply manifests run: | cd apps/training-operator/upstream kubectl create ns kubeflow kustomize build overlays/kubeflow | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/twa_kind_test.yaml b/.github/workflows/twa_kind_test.yaml index b211f476db..afb74e6af5 100644 --- a/.github/workflows/twa_kind_test.yaml +++ b/.github/workflows/twa_kind_test.yaml @@ -21,14 +21,11 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Build & Apply manifests run: | cd apps/tensorboard/tensorboards-web-app/upstream kubectl create ns kubeflow kustomize build overlays/istio | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/.github/workflows/vwa_kind_test.yaml b/.github/workflows/vwa_kind_test.yaml index b87ac04d2b..b5822d2f9e 100644 --- a/.github/workflows/vwa_kind_test.yaml +++ b/.github/workflows/vwa_kind_test.yaml @@ -21,14 +21,11 @@ jobs: run: ./testing/gh-actions/install_kustomize.sh - name: Install Istio - run: | - cd common/istio-1-11 - kustomize build istio-crds/base | kubectl apply -f - - kustomize build istio-namespace/base | kubectl apply -f - - kustomize build istio-install/base | kubectl apply -f - + run: ./testing/gh-actions/install_istio.sh - name: Build & Apply manifests run: | cd apps/volumes-web-app/upstream kubectl create ns kubeflow kustomize build overlays/istio | kubectl apply -f - + kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s diff --git a/testing/gh-actions/install_cert_manager.sh b/testing/gh-actions/install_cert_manager.sh new file mode 100755 index 0000000000..dcb855abc4 --- /dev/null +++ b/testing/gh-actions/install_cert_manager.sh @@ -0,0 +1,9 @@ +#!/bin/bash +set -e +echo "Installing cert-manager ..." +cd common/cert-manager +kubectl create namespace cert-manager +kustomize build cert-manager/base | kubectl apply -f - +echo "Waiting for cert-manager to be ready ..." +kubectl wait --for=condition=ready pod -l 'app in (cert-manager,webhook)' --timeout=180s -n cert-manager +kustomize build kubeflow-issuer/base | kubectl apply -f - \ No newline at end of file diff --git a/testing/gh-actions/install_istio.sh b/testing/gh-actions/install_istio.sh new file mode 100755 index 0000000000..7513c882c4 --- /dev/null +++ b/testing/gh-actions/install_istio.sh @@ -0,0 +1,7 @@ +#!/bin/bash +set -e +echo "Installing Istio ..." +cd common/istio-1-11 +kustomize build istio-crds/base | kubectl apply -f - +kustomize build istio-namespace/base | kubectl apply -f - +kustomize build istio-install/base | kubectl apply -f - \ No newline at end of file