Profiles deployment has missing port

[svilenvul]

We have installed Kubeflow with the vanilla deployment configuration in the cluster and we have setup Istio routing to it with SDS. After this we got an error in the UI ("Unable to contact Profile Controller").

The access to the profiles-kfam.kubeflow service was blocked. I found out that there is no ports section in the profiles deployment. When I added the following snippet the problem was resolved:

spec:
  ...
  template:
    ...
    spec:
      ...
      containers:
      - name kfam
        ports:
        - containerPort: 8081
          name: kfam-http
          protocol: TCP

[issue-label-bot]

Issue-Label Bot is automatically applying the labels:

Label	Probability
bug	0.89

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

[Bobgy]

/assign @Bobgy
I will submit a PR for this

[Bobgy]

Related istio issue: istio/istio#15633

With current istio 1.1.6, we must add the port to let mTLS work with kfam, but if we upgrade istio, the requirement will be removed.

However, sounds like declaring the port to this deployment is anyway a good annotation, so I'm going to submit the PR now.