Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Metadata Writer for KFP #897

Closed
jlewi opened this issue Feb 11, 2020 · 12 comments · Fixed by #1248
Closed

Enable Metadata Writer for KFP #897

jlewi opened this issue Feb 11, 2020 · 12 comments · Fixed by #1248

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 11, 2020

See this comment
#796 (comment)

KFP and metadata need to be configured correctly to enable the metadata writer service.

/cc @elikatsis @Ark-kun

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.70

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented Feb 26, 2020

@Ark-kun any interest in picking this up?

Some relevant links
https://github.com/kubeflow/pipelines/tree/master/backend/metadata_writer

@elikatsis
Copy link
Member

@jlewi We first need to merge kubeflow/pipelines#3108

@Ark-kun
Copy link

Ark-kun commented Mar 11, 2020

/cc @dushyanthsc

@jlewi
Copy link
Contributor Author

jlewi commented May 18, 2020

@elikatsis @dushyanthsc any update on this?

@elikatsis
Copy link
Member

Hi @jlewi,

I believe MetadataWriter implementation as well as the related KFP manifests are compatible with KF manifests. So it should be easy to extend these manifests to deploy metadata writer.

I'll let @dushyanthsc or @rmgogogo verify.

@dushyanthsc
Copy link
Contributor

We updated the manifest to be consistent. Is there anything else required to change on the Metadata (gRPC) deployments to enable metadata-writer @Ark-kun ?

@jlewi
Copy link
Contributor Author

jlewi commented Jun 15, 2020

Downgrading to p2 and removing from KF 1.1. because it doesn't look like we have a clear owner so it doesn't seem like its going to get completed.

/cc @aronchick @karlschriek

@Ark-kun
Copy link

Ark-kun commented Jun 16, 2020

Is there anything else required to change on the Metadata (gRPC) deployments to enable metadata-writer @Ark-kun ?

No. Metadata Writer is standalone and should be compatible with the rest of the deployments (after the GRPC vs. HTTP service names were fixed).

@Ark-kun
Copy link

Ark-kun commented Jun 16, 2020

@jlewi I think we just need to add the Metadata Writer deployment (deployment, SA, role, binding) manifests to KF.

@Ark-kun
Copy link

Ark-kun commented Jun 16, 2020

/cc @rmgogogo @Bobgy

@Ark-kun
Copy link

Ark-kun commented Jun 16, 2020

Looks like #1248 fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants