-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize package to setup a namespace for using Kubeflow (alternative to profile controller) #1136
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
Some additional features to think about as following
|
In general I like a declarative approach but as described here, it would require some glue I'd prefer we could avoid: We're using an authenticating (via LDAP) reverse proxy in front of kubeflow that sets trusted user identity headers. That means right now we just need to grant users access to that proxy and when they log in the first time, they can create their namespace. With the proposed change, we would have add glue to poll LDAP and add/delete namespaces from the kustomize package dynamically. That's definitely doable but I feel like many people would have to solve that somehow. So the ideal solution to me would be if the profile controller creates a namespace (non-interactively) automatically based on some sort of declarative template. |
I don't think its necessarily a one size fits all. If you want to to propose and build out the case for doing things programmatically/automatically that sounds good to me. On GCP what we are seeing is that
Automatic creation probably won't work in our case because typically each namespace will require some user defined input that will vary from customer to customer. A simple case is how customers map namespaces to GCP service accounts. |
Ok makes sense. I think whatever the outcome of this will be, it should be possible to build whatever automation on top. |
@lalithvaka any interest at taking an initial stab at this issue? |
@lalithvaka and @bmorphism any progress on this? |
@jlewi if no one else has picked this up I don't mind giving it a go? Seems fairly straight forward and helps with my particular use case |
@connorlwilkes That would be fantastic! |
@jlewi brilliant. I may come back with some queries on current implementation and approach. |
@connorlwilkes Have you made progress on this? It would be quite useful for my team |
A quick suggestion for anyone interested in picking this up; create a profile and then just dump all the K8s resources for the namespace.
That would probably provide a good starting point. I would then turn that into a kpt package using the kpt CLI tool. Something like
kpt provides a real nice way to make it reusable. At least that's what I plan on doing if I find myself blocked on this. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions. |
This issue has been closed due to inactivity. |
We need a kustomize package that sets up a namespace for using Kubeflow. This package should basically do everything the profile controller is doing. e.g.
A declarative approach to namespace setup should better support platform teams looking to setup and control kubeflow deployments on behalf of multiple teams. See the discussion in this thread
Creating a controller to setup namespaces made sense if we were trying to create an abstraction to hide the details of namespace to support programmatic creation e.g. through the UI.
However, as discussed in that thread we are seeing friction around that approach particularly for platform teams.
To support platform-teams I think we want to move in the direction of GitOps. If a team is using GitOps to bootstrap individual namespaces then using a controller makes less sense then just providing a kustomize package for the relevant K8s resources.
The text was updated successfully, but these errors were encountered: