From 66bc834c2bdc1b1fda7471f7677ef7b8b72f863c Mon Sep 17 00:00:00 2001 From: hougang liu Date: Tue, 28 May 2019 18:27:09 +0800 Subject: [PATCH] Mini fix for v1alpha1 metricsCollector --- pkg/manager/v1alpha1/metricscollector/metricscollector.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/manager/v1alpha1/metricscollector/metricscollector.go b/pkg/manager/v1alpha1/metricscollector/metricscollector.go index cef8e1c28fc..528045cf0db 100644 --- a/pkg/manager/v1alpha1/metricscollector/metricscollector.go +++ b/pkg/manager/v1alpha1/metricscollector/metricscollector.go @@ -47,7 +47,10 @@ func (d *MetricsCollector) CollectWorkerLog(wID string, wkind string, objectiveV } else { labelMap["job-name"] = wID } - pl, _ := d.clientset.CoreV1().Pods(namespace).List(metav1.ListOptions{LabelSelector: labels.Set(labelMap).String(), IncludeUninitialized: true}) + pl, err := d.clientset.CoreV1().Pods(namespace).List(metav1.ListOptions{LabelSelector: labels.Set(labelMap).String(), IncludeUninitialized: true}) + if err != nil { + return nil, err + } if len(pl.Items) == 0 { return nil, errors.New(fmt.Sprintf("No Pods are found in Job %v", wID)) }