Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Kotlin 2.0.0 #421

Open
MasWag opened this issue May 26, 2024 · 8 comments
Open

Does not work with Kotlin 2.0.0 #421

MasWag opened this issue May 26, 2024 · 8 comments

Comments

@MasWag
Copy link

MasWag commented May 26, 2024

It seems kscript does not work with Kotlin 2.0.0. What I observe is the same as #408:

$ kscript 'println("hello world")' 

Exception in thread "main" java.lang.ClassNotFoundException: kscript.scriplet.Scriplet
	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
	at Main_Scriplet$Companion.main(Main_Scriplet.kt:5)
	at Main_Scriplet.main(Main_Scriplet.kt)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.jetbrains.kotlin.runner.AbstractRunner.run(runners.kt:70)
	at org.jetbrains.kotlin.runner.Main.run(Main.kt:183)
	at org.jetbrains.kotlin.runner.Main.main(Main.kt:193)
[kscript] [ERROR] Execution of scriplet failed:
[kscript] [ERROR] Command     : 'bash -c /opt/homebrew/Cellar/kotlin/2.0.0/libexec/bin/kotlin  -classpath '/Users/mwaga/Library/Caches/kscript/jar_7a6cdcc8b547b2bb2a0ad2ab4f24c291/scriplet.jar:/opt/homebrew/Cellar/kotlin/2.0.0/libexec/lib/kotlin-script-runtime.jar' Main_Scriplet '
[kscript] [ERROR] Exit Code   : 1   
[kscript] [ERROR] 

It works well with Kotlin 1.9.24 (after cache removal).

$ brew unlink kotlin && brew link kotlin@1.9.24  && rm -rf ~/Library/Caches/kscript/ && kscript 'println("hello world")'
Unlinking /opt/homebrew/Cellar/kotlin/2.0.0... 6 symlinks removed.
Linking /opt/homebrew/Cellar/kotlin@1.9.24/1.9.24... 6 symlinks created.
hello world
@NoUsernameProvided
Copy link

Same issue here.

@zorenkonte
Copy link

Got the same error

@aartiPl
Copy link
Collaborator

aartiPl commented Jun 12, 2024

I will try to solve it, although I don't have much time to invest. Contributions from anyone are more than welcome.

@aartiPl
Copy link
Collaborator

aartiPl commented Sep 11, 2024

I have investigated the issue. The problem with version 2.0 is that it completely changes how the scripts are executed. The current way of executing the script is by wrapping it with the following code:

fun createWrapperForScript(packageName: PackageName, className: String): String {

But now, this method does not work anymore.

I was also thinking about a more sophisticated way of rewriting the script so that it is put inside
fun main() {}
block. But it will only work for some cases - for example, enum class {} can not be defined in the function's local scope, so it will fail if you try to define an enum in your script.

The only possible alternative I can see is to use the Kotlin script engine to implement the KScript engine. I have started the branch with those changes, but I don't have time to accomplish that work:

val kscriptHost = KscriptHost(config.osConfig.cacheDir)

If anyone wants to take on this task, feel free to do so. I will accept the MRs.

@Dogacel
Copy link

Dogacel commented Oct 15, 2024

@aartiPl if it doesn't work with kotlin 2.0+, is it possible to select which version of kotlin compiler to use? I tried using this for the first time and having the same error.

Maybe we need an environment manager like jenv for kotlin.

@sergeych
Copy link

kscript is excellent and missing feature. it has to be upgraded to support koglin 2+, as many new code won't run with older versions, while kotlin's scripting itself is yet practically unusable. Thanks for incredible tool anyway... it was a great time using it.

@appreciated
Copy link

appreciated commented Feb 5, 2025

For others facing this issue, I faced a slightly different error message:

Exception in thread "main" java.lang.ClassNotFoundException: kscript.scriplet.Client

As a workaround, until there is kotlin 2.0 support, you can downgrade the kotlin version using sdkman:

sdk install kotlin 1.9.24

@kamilmodest
Copy link

kamilmodest commented Feb 12, 2025

For me, it doesn't work with 1.9.24 either 🤔

Macbooc M2 Pro (arm)

Installed via

╰─>  sdk install kotlin 1.9.24
╰─>  sdk install kscript
╰─>  where kotlin
/Users/k.babaev/.sdkman/candidates/kotlin/current/bin/kotlin
╰─>  where kscript
/Users/k.babaev/.sdkman/candidates/kscript/current/bin/kscript

Runs:

╰─>  kscript 'println("hello world")'
Exception in thread "main" java.lang.ClassNotFoundException: kscript.scriplet.Scriplet
	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
	at Main_Scriplet$Companion.main(Main_Scriplet.kt:5)
	at Main_Scriplet.main(Main_Scriplet.kt)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.jetbrains.kotlin.runner.AbstractRunner.run(runners.kt:70)
	at org.jetbrains.kotlin.runner.Main.run(Main.kt:194)
	at org.jetbrains.kotlin.runner.Main.main(Main.kt:204)
[kscript] [ERROR] Execution of scriplet failed:
[kscript] [ERROR] Command     : 'bash -c /Users/k.babaev/.sdkman/candidates/kotlin/1.9.24/bin/kotlin  -classpath '/Users/k.babaev/Library/Caches/kscript/jar_7a6cdcc8b547b2bb2a0ad2ab4f24c291/scriplet.jar:/Users/k.babaev/.sdkman/candidates/kotlin/1.9.24/lib/kotlin-script-runtime.jar' Main_Scriplet '
[kscript] [ERROR] Exit Code   : 1
[kscript] [ERROR]
╰─>  ll /Users/k.babaev/.sdkman/candidates/kscript
Permissions Size User     Group Date Modified    Name
drwxr-xr-x@    - k.babaev staff 2023-07-22 12:07  4.2.3
lrwxr-xr-x@    - k.babaev staff 2025-02-12 18:56  current -> 4.2.3

╰─>  ll /Users/k.babaev/.sdkman/candidates/kotlin
Permissions Size User     Group Date Modified    Name
drwxr-xr-x@    - k.babaev staff 1980-02-01 00:00  1.9.24
lrwxr-xr-x@    - k.babaev staff 2025-02-12 18:39  current -> 1.9.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants