-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to change the current selection's highlight color in zsh? #2419
Comments
This will be because whatever you have used to configure the colors for Details at: hishamhm/htop#35 (comment) |
@ritiek did you manage to sort it out? For now I use the following trick: theme.conf
result: It looks good enough IMO but I miss the selection rectangle I have when no background picture is used: |
Nope. Seems like zsh doesn't offer a config option for setting this selection color. I also tried to dig in zsh's high-level sources but couldn't find anything interesting there either. This color setting is probably somewhere deep in zsh's core sources. |
Its definitely not anything in zsh's core sources. I use zsh with kitty myself, and this problem does not exist. Start with any empty zshrc and bisect it to find the problem. |
I should've posted a more informative comment, sorry about that! If I completely empty my I face the original issue when ohmyzsh is enabled and I traced it to this line at fault: zstyle ':completion:*:*:*:*:*' menu select from Now if I completely empty my |
You need to figure out where zsh is getting its colors from, most likely |
I dumped what zsh is sending (by setting the scrollback_pager to tee), and what it sends is As far as I understand, the issue is that when |
So then a reproducer would be:
|
Thank you! 5d65cdb does solve this issue for me and I get the same behaviour as gnome-terminal in original post. |
Hi, and thanks for making Kitty!
Kitty seems to be using black foreground color for highlightning selected items when using zsh's tab auto-complete. This makes it really hard to read the text for current selection on dark backgrounds.
For example this gif, when hitting tab key in zsh for listing and selecting files in current directory:
However, when using gnome-terminal and doing the same, the selected file is highlighted with a white background and a black foreground:
which is easier to read.
Is it possible to change this black foregound highlight color in Kitty to something else?
I've tried setting the values for
selection_foreground
andselection_background
but they seem to only affect colors for selections made using a mouse.The text was updated successfully, but these errors were encountered: