You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a lot of falsey checks in this library rather than undefined checks. Here's one, for example. I'm wondering if these should be switched to null/undefined checks (x == null) as it appears that empty header values are valid according to the HTTP RFC. I'm wondering this is that I'm working with an API that is behaving weirdly (returns Pragma: no-cache alongside Cache-Control: ) when I send over a Cache-Control: max-age=3600 header in the request, which is causing this library to consider the response to not be cacheable. Thx!
The text was updated successfully, but these errors were encountered:
There are a lot of falsey checks in this library rather than undefined checks. Here's one, for example. I'm wondering if these should be switched to null/undefined checks (
x == null
) as it appears that empty header values are valid according to the HTTP RFC. I'm wondering this is that I'm working with an API that is behaving weirdly (returnsPragma: no-cache
alongsideCache-Control:
) when I send over aCache-Control: max-age=3600
header in the request, which is causing this library to consider the response to not be cacheable. Thx!The text was updated successfully, but these errors were encountered: