Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngrok memory leak #1099

Closed
converge opened this issue Jan 11, 2023 · 2 comments
Closed

ngrok memory leak #1099

converge opened this issue Jan 11, 2023 · 2 comments

Comments

@converge
Copy link
Contributor

As a Kubefirst developer I want to handle a channel that is open for ngrok. So that, after the channel is not in use anymore, we close the running go routine and avoid memory leak.

AC1: ngrok functionality behaves the same
AC2: the opened channel is closed when the installation finish

@6za
Copy link
Contributor

6za commented Jan 11, 2023

Once the channel is closed, atlantis will not be usable on local. Is this the intended behavior?

@converge
Copy link
Contributor Author

Once the channel is closed, atlantis will not be usable on local. Is this the intended behavior?

yes, a non closed channel is a memory leak, we can close the channel before exiting the main process/kubefirst install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants