From e20e1b7699d82a632fed6861280d91c332067f35 Mon Sep 17 00:00:00 2001 From: Luc Berger-Vergiat Date: Wed, 14 Feb 2024 10:22:47 -0700 Subject: [PATCH] Lapack - SVD: adding quick return when cuSOLVER is skipped Currently we still run the tests on U, S and Vt which does not make sense since we actively skip this test because cuSOLVER does not support more columns than rows... --- lapack/unit_test/Test_Lapack_svd.hpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lapack/unit_test/Test_Lapack_svd.hpp b/lapack/unit_test/Test_Lapack_svd.hpp index 032b9f86c6..3b2cd3d8d5 100644 --- a/lapack/unit_test/Test_Lapack_svd.hpp +++ b/lapack/unit_test/Test_Lapack_svd.hpp @@ -474,9 +474,6 @@ int impl_test_svd(const int m, const int n) { using vector_type = Kokkos::View; - std::cout << "Running impl_test_svd with sizes: " << m << "x" << n - << std::endl; - const mag_type max_val = 10; const mag_type tol = 1000 * max_val * KAT_S::eps(); @@ -499,6 +496,8 @@ int impl_test_svd(const int m, const int n) { Kokkos::Cuda>) { if (m >= n) { KokkosLapack::svd("A", "A", A, S, U, Vt); + } else { + return 0; } } else { KokkosLapack::svd("A", "A", A, S, U, Vt);