Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camelot Key on S4mk3 #29

Open
yuletide opened this issue Mar 31, 2019 · 5 comments
Open

Camelot Key on S4mk3 #29

yuletide opened this issue Mar 31, 2019 · 5 comments

Comments

@yuletide
Copy link

yuletide commented Mar 31, 2019

Hey folks,
Just got an s4mk3 and was sent here by another fan. I'm very new to QT but managed to get Camelot keys to show, but not while respecting the preference setting -- I'm guessing because of the nested if's. Is there a better way to do this?

text: deckInfo.hasKey ? (prefs.camelotKey ? utils.convertToCamelot(deckInfo.keyString) : deckInfo.keyString) : "No key"

When I take out the preference check it works fine:

yuletide@4371ff3

Edit: Thought I fixed it but not quite there. If prefs.camelotKey = false it just shows "No Key" for every track. If true then we get camelot keys
yuletide@39c540e

@kokernutz
Copy link
Owner

Heya!

Nice work!

I ordered an S4 MK3 and it's getting delivered on Wednesday. I was going to update my mods so it displays Camelot keys on the new controller. Can you wait until then?

@yuletide
Copy link
Author

@kokernutz Of course! I also added in setting key text color based on your utility functions which looks great. Excited to see what else we can do with these little screens.

Unrelated, but have you any experience creating mappings? My next attempt was to somehow change master tempo (there's no knob), but I think we can do that without messing about in qml

@kokernutz
Copy link
Owner

Yes, I made a keyboard mapping so I could prep tracks quickly.

Doesn't SHIFT-TEMPO FADER do that? I had an S4 MK2 years ago and vaguely remember that.

@yuletide
Copy link
Author

So it seems shift-fader does literally nothing which is actually useful since you can reset the fader position to neutral without sending any signal. I just discovered it this last second which solved my problem of running out of fader room when set to relative and loading a new track with the fader already down

@kokernutz
Copy link
Owner

Ah yes, that's it. Still need a mapping to fix master tempo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants