Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is offer status ACTIVE on offers that are expired? #5803

Closed
JustLuuuu opened this issue Apr 25, 2023 · 3 comments
Closed

Why is offer status ACTIVE on offers that are expired? #5803

JustLuuuu opened this issue Apr 25, 2023 · 3 comments
Labels
A-basilisk issues related to basilisk parachain bug Something isn't working

Comments

@JustLuuuu
Copy link
Member

Can someone explain me this? Why is the status active if the offer is expired?
Go to your profile - offers made:
Screenshot 2023-04-25 at 09 17 36

Is that intention or a bug? When the offer expires, the status should change to something else.

@JustLuuuu JustLuuuu added bug Something isn't working A-basilisk issues related to basilisk parachain labels Apr 25, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Apr 25, 2023

Can someone explain me this? Why is the status active if the offer is expired?

Offer is still ACTIVE but expired means that your offer amount (0.1000KSM) is still fronzen on chain.
You need to withdraw it in order to recover the amount. (#3790 (comment))

Is that intention or a bug?

it is indeed intentional (we have many issues related with this like #3401)

When the offer expires, the status should change to something else.

Well since offer is still "ACTIVE" what should be the status then?

@JustLuuuu
Copy link
Member Author

Offer is still ACTIVE but expired means that your offer amount (0.1000KSM) is still fronzen on chain. You need to withdraw it in order to recover the amount. (#3790 (comment))

Okay, I understand now. I did not know I needed to cancel my offer even after it had expired. I think we should add this information somewhere for people like me. 😄 Maybe just small text under the table saying that: if your offer is expired, cancel it to release your locked KSM.

I checked active offers in stats and there are a lot of them that are expired and still active:
Screenshot 2023-04-25 at 10 38 52

Well since the offer is still "ACTIVE" what should be the status then?

In this case, keep it - now I understand the point of it 😅

Isn't it possible to make it automatic? Releasing KSM after expiration?

@roiLeo
Copy link
Contributor

roiLeo commented Apr 25, 2023

Maybe just small text under the table saying that: if your offer is expired, cancel it to release your locked KSM.

🆙 this!

Isn't it possible to make it automatic? Releasing KSM after expiration?

Nope I don't think it's possible since only NftOwner or the person sending the offer CAN withdraw the offer.
(ref kodadot/snek#13 to handle expired offers)

@roiLeo roiLeo mentioned this issue May 15, 2023
8 tasks
@roiLeo roiLeo closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-basilisk issues related to basilisk parachain bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants