Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new collection card on profile as we have on explorer #5032

Closed
exezbcz opened this issue Feb 16, 2023 · 11 comments
Closed

Use new collection card on profile as we have on explorer #5032

exezbcz opened this issue Feb 16, 2023 · 11 comments
Labels
$ ~<50usd A-profile related to profile section p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented Feb 16, 2023

replace it with new collection card - same as on explore

image
image

@exezbcz exezbcz added UX first Improvement for UX p3 non-core, affecting less than 40% labels Feb 16, 2023
@Jarsen136
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Feb 17, 2023

ASSIGNED - @Jarsen136 🔒 LOCKED -> Saturday, February 18th 2023, 13:26:22 UTC -> 36 hours

@vikiival
Copy link
Member

vikiival commented Mar 6, 2023

We need to write resolvers for that

indexer side:

snek: kodadot/snek#142
rubick: kodadot/loligo#10
frontend side:

update collectionListWithSearch.graphql for collection search
update collectionListByAccount.graphql for collection in the user profile page
refactor components/collection/CollectionCard.vue and components/collection/CollectionDetail.vue

@kodabot
Copy link
Collaborator

kodabot commented Mar 6, 2023

ASSIGNMENT EXPIRED - @Jarsen136 has been unassigned.

@Jarsen136
Copy link
Contributor

Let's wait for someone could write the resolver on the indexer side.

@Jarsen136 Jarsen136 removed their assignment Mar 6, 2023
@vikiival
Copy link
Member

vikiival commented Mar 7, 2023

actually there is series resolver which was added by @roiLeo and that can help :)

@yangwao yangwao added the A-profile related to profile section label Apr 11, 2023
@yangwao yangwao changed the title Replace old collection card on profile Use new collection card on profile as we have on explorer Apr 11, 2023
@alko89
Copy link

alko89 commented Apr 11, 2023

indexer side:

snek: kodadot/snek#142 rubick: kodadot/loligo#10

@vikiival sorry for dumb question, but where should these resolvers reside? 😅 loligo repo is empty and there is no reference to collectionEntitiesConnection in snek

@vikiival
Copy link
Member

sorry for dumb question

There is no dumb question

loligo repo is empty

Loligo is repo for tasks that should be implemented on both rubick and snek

where should these resolvers reside?

They usually chill in src/server-extension

@yangwao yangwao added p2 core functionality, or is affecting 60% of app $ ~<50usd and removed p3 non-core, affecting less than 40% labels Apr 18, 2023
@exezbcz
Copy link
Member Author

exezbcz commented Aug 9, 2023

Any update on this? Would help me create a transition profile page

@preschian
Copy link
Member

Any update on this? Would help me create a transition profile page

seems blocked on the indexer side. Maybe we can continue on the collection tab later?

I already initiated a placeholder to use a similar design to the collection page https://canary.kodadot.xyz/ahk/u/CtkRtkQkkShfDxG4craGJnqb6oMQfjK5aF6gKoSrN1uTsuh?page=1&redesign=true.

But if that is drastically different from your design, we can drop that

@exezbcz
Copy link
Member Author

exezbcz commented Aug 9, 2023

@preschian Actually, I will make an issue for a transitional profile soon till we figure out multichain, follow, verification, edit of the profile, etc. I am reusing as much layout as possible so it will be fast and not complicated.

So more than this pr is needed in order for the collection cards to work?

@exezbcz exezbcz mentioned this issue Aug 10, 2023
@exezbcz exezbcz closed this as completed Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-profile related to profile section p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants