Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass transfer feature #11072

Closed
JustLuuuu opened this issue Oct 1, 2024 · 3 comments · Fixed by #11096
Closed

Mass transfer feature #11072

JustLuuuu opened this issue Oct 1, 2024 · 3 comments · Fixed by #11096
Assignees
Labels
A-transfer payment processing in transfer enhancement New feature or request

Comments

@JustLuuuu
Copy link
Member

Once in a while, you want to send more NFTs to various addresses or transfer more NFTs to your second wallet. We don't have a way to do it!

Can we please think about having a mass transfer feature?

Where it can be used

  • giveaway and competitions
  • when transferring more NFTs to another wallet

It will make things faster!

@kodadot/internal-dev, how hard is it to implement that?

@JustLuuuu JustLuuuu added enhancement New feature or request A-transfer payment processing in transfer labels Oct 1, 2024
@hassnian
Copy link
Contributor

hassnian commented Oct 3, 2024

@kodadot/internal-dev, how hard is it to implement that?

we already have something similar with mass listing, surely we can reuse some of that code

design is needed cc @exezbcz

@exezbcz
Copy link
Member

exezbcz commented Oct 5, 2024

sure, on it

@exezbcz
Copy link
Member

exezbcz commented Oct 7, 2024

Design

available in: https://www.figma.com/design/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=2734-21138&node-type=canvas&t=oxF8FbhJCCMbV6sW-11

image

shares a lot from transfer component, offer notification system, signing. Main part where the items are displayed in the modal is taken from the success modal when mass buying

Toast when selecting items

  • here is a small change: new button for transfer alongside the list items button
    image
  • they are both medium buttons, check the padding
  • buttons follow button style guide

After clicking transfer

you are presented with a modal that has a list of items

  • its the same list you have when mass buying
  • transfer to:
    • same as a transfer modal for single nfts
  • don't forget about different states for the input
    more here:
    image

https://www.figma.com/design/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=1287-18959&node-type=canvas&t=oxF8FbhJCCMbV6sW-11

Sign and toast

  • there won't a be congrats modal, there is not many converting actions after the transfer - it means it will be a progress toast, and then congrats

image

same as offers just with different copy and in the congrats toas there is a link for the transaction

other

  • let me know if i have missed anything
  • mass transfer is disabled on mobile since you cannot hover over the card and select it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transfer payment processing in transfer enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants