Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for more frequent releases #1838

Open
wknapik opened this issue Feb 14, 2020 · 15 comments
Open

Request for more frequent releases #1838

wknapik opened this issue Feb 14, 2020 · 15 comments

Comments

@wknapik
Copy link

wknapik commented Feb 14, 2020

Hi. Can you please release more frequently ? It's especially relevant in CI.

@koalaman
Copy link
Owner

What's the goal here? More up-to-date checks without the instability of git builds?

@matthewpersico
Copy link

matthewpersico commented Feb 16, 2020 via email

@dimo414
Copy link
Contributor

dimo414 commented Feb 22, 2020

Seems like a policy problem if you can't use the code you need just because it lacks a GitHub tag. You should be evaluating software for production safety based on its content, not whether the maintainer has made it "official".

Nevertheless, it looks like the last release was in Jul 2019, it would be nice to push out all the changes that have landed since then. So +1 to the FR just since releases are often easier to work with. Especially for folks getting ShellCheck via a package manager like apt-get.

@matthewpersico
Copy link

matthewpersico commented Feb 22, 2020 via email

@matthewpersico
Copy link

The automatic vetting includes confirming that there is a license file in the code and that the license is an acceptable Open Source one.

@matthewpersico
Copy link

And yes, the "owner" of the code internally is responsible for content evaluation.

@zemanlx
Copy link

zemanlx commented Feb 25, 2020

It would be nice to get changes that are needed for stack 15.1 / ghc 8.8.2 into release so we can build on them.

@wknapik
Copy link
Author

wknapik commented Feb 25, 2020

@koalaman while all of the above reasons apply, for me it's primarily about getting up-to-date shellcheck binaries without too much hassle (like building from source).

I execute my CI pipeline stages inside docker containers, which means I have two reasonable ways of getting the shellcheck binary - either by installing it from a distro package, or by doing something like this:

ENV SHELLCHECK_URL https://storage.googleapis.com/shellcheck/shellcheck-v0.7.0.linux.x86_64.tar.xz
RUN curl -fsSL -o- "$SHELLCHECK_URL"|tar -Jx "$(echo "$SHELLCHECK_URL"|grep -oP 'shellcheck-v\d+\.\d+\.\d+')/shellcheck" -O >"$EXEC_DIR/shellcheck"

Both methods require an official release.

I think the most relevant argument for more frequent releases is to allow distros (and by extension users) to keep up to date.

@arrowd
Copy link

arrowd commented Mar 13, 2020

A bit irrelevant to this thread, but what's difference between latest 0.7 release on Hackage and GitHub?

Github one was released 8 days ago, while Hackage one was released in July last year. And both of them have the same version.

@koalaman
Copy link
Owner

I've been meaning to post about that! See #1871

tl;dr: It's the same, I just want to start serving releases from GitHub rather than GCS. If your CI downloads an official binary release, please update the URL when you get a chance.

@arrowd
Copy link

arrowd commented Mar 13, 2020

That means, there will be no Hackage releases anymore?

@koalaman
Copy link
Owner

Hackage releases will continue as usual. This only affects precompiled binaries.

@arrowd
Copy link

arrowd commented Mar 13, 2020

Ok, glad to hear that!

@diederikdehaas
Copy link

Can we have a new release before Debian Bullseye is released?
Debian Sid now has version 0.7.1, but there have been 133 commits since.
The debian/watch file checks https://hackage.haskell.org/package/ShellCheck/distro-monitor but I'm assuming there's a (strong) correlation between releases there and releases/tags here.

Debian Bullseye's freeze policy can be found here: https://release.debian.org/testing/freeze_policy.html

@samueloph
Copy link

Debian maintainer of shellcheck here,

Due to the bullseye freeze, we are out of time to ship any new releases.

I'm not saying this to put pressure on upstream, and I will continue to provide new shellcheck releases under our backports repository for our stable releases (bullseye).

FWIW we can also check for github releases instead of hackage, but as I understood, hackage will be kept in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants