From 634ea8c4cd6d60a46dbdb0a196165326ec1bd188 Mon Sep 17 00:00:00 2001 From: Bart Hijmans Date: Fri, 25 Jun 2021 10:24:31 +0200 Subject: [PATCH 1/2] Moved 'blademd' registration in serviceprovider from register to boot method. --- src/ScribeServiceProvider.php | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/ScribeServiceProvider.php b/src/ScribeServiceProvider.php index 410599e7..27bea165 100644 --- a/src/ScribeServiceProvider.php +++ b/src/ScribeServiceProvider.php @@ -13,15 +13,6 @@ class ScribeServiceProvider extends ServiceProvider { - public function register() - { - // Register custom Markdown Blade compiler so we can automatically have MD views converted to HTML - $app = $this->app; - $app->view->getEngineResolver() - ->register('blademd', fn() => new BladeMarkdownEngine($app['blade.compiler'])); - $app->view->addExtension('md.blade.php', 'blademd'); - } - /** * Bootstrap the application events. * @@ -29,6 +20,12 @@ public function register() */ public function boot() { + // Register custom Markdown Blade compiler so we can automatically have MD views converted to HTML + $app = $this->app; + $app->view->getEngineResolver() + ->register('blademd', fn() => new BladeMarkdownEngine($app['blade.compiler'])); + $app->view->addExtension('md.blade.php', 'blademd'); + $this->loadViewsFrom(__DIR__ . '/../resources/views/', 'scribe'); // Publish views in separate, smaller groups for ease of end-user modifications From 5f77ee13b4ec67d40d13eefe5c82a0d47f0577e4 Mon Sep 17 00:00:00 2001 From: Bart Hijmans Date: Fri, 25 Jun 2021 10:27:49 +0200 Subject: [PATCH 2/2] Removed unnecessary local variable --- src/ScribeServiceProvider.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/ScribeServiceProvider.php b/src/ScribeServiceProvider.php index 27bea165..0b868a70 100644 --- a/src/ScribeServiceProvider.php +++ b/src/ScribeServiceProvider.php @@ -21,10 +21,9 @@ class ScribeServiceProvider extends ServiceProvider public function boot() { // Register custom Markdown Blade compiler so we can automatically have MD views converted to HTML - $app = $this->app; - $app->view->getEngineResolver() - ->register('blademd', fn() => new BladeMarkdownEngine($app['blade.compiler'])); - $app->view->addExtension('md.blade.php', 'blademd'); + $this->app->view->getEngineResolver() + ->register('blademd', fn() => new BladeMarkdownEngine($this->app['blade.compiler'])); + $this->app->view->addExtension('md.blade.php', 'blademd'); $this->loadViewsFrom(__DIR__ . '/../resources/views/', 'scribe');