From 0b9473b5cd8046df9fb230b36fff61b3159e9fb2 Mon Sep 17 00:00:00 2001 From: shalvah Date: Fri, 18 Nov 2022 22:59:51 +0100 Subject: [PATCH] Smarter description (singular v plural) --- src/Extracting/ParsesValidationRules.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/Extracting/ParsesValidationRules.php b/src/Extracting/ParsesValidationRules.php index cd121a4e..a75e2f90 100644 --- a/src/Extracting/ParsesValidationRules.php +++ b/src/Extracting/ParsesValidationRules.php @@ -669,10 +669,14 @@ protected function getDescription(string $rule, array $arguments = [], $baseType $description = str_replace($placeholder, $argument, $description); } - // FOr rules that validate subfields - $description = str_replace("The :attribute field", "This field", $description); - - return str_replace("The value must", "Must", str_replace(":attribute", "value", $description)); + // For rules that validate subfields + $description = str_replace("The :attribute field ", "This field ", $description); + + return str_replace( + [" :attribute ", "The value must ", " 1 characters", " 1 digits", " 1 kilobytes"], + [" value ", "Must ", " 1 character", " 1 digit", " 1 kilobyte"], + $description + ); } private function getLaravelValidationBaseTypeMapping(string $parameterType): string