Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.18 client-go library #1009

Closed
rhuss opened this issue Sep 14, 2020 · 6 comments
Closed

Update to 1.18 client-go library #1009

rhuss opened this issue Sep 14, 2020 · 6 comments
Assignees
@MIBc
Milestone
v0.18.0

Comments

@rhuss
Copy link
Contributor

rhuss commented Sep 14, 2020

Update the dependency on client-go to version 1.18 which introduces some backward incompatible changes. See also https://knative.slack.com/archives/C01AK3YNHPW for the knative coordinated effort to make the switch.
@MIBc
Copy link
Contributor

MIBc commented Sep 15, 2020

Should we update only client-go or all k8s library ?

@MIBc MIBc mentioned this issue Sep 15, 2020
Closed
@rhuss
Copy link
Contributor Author

rhuss commented Sep 15, 2020

We should align with the other knative projects, I think they have updated everything to k8s 1.18

@MIBc
Copy link
Contributor

MIBc commented Sep 15, 2020

/assign

@mattmoor
Copy link
Member

Generally we move all K8s libs in sync.

@MIBc
Copy link
Contributor

MIBc commented Sep 26, 2020

I think this issue has been solved by #1025. We can close it.

@rhuss
Copy link
Contributor Author

rhuss commented Sep 29, 2020

Correct

@rhuss rhuss closed this as completed Sep 29, 2020
@navidshaikh navidshaikh added this to the v0.18.0 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MIBc MIBc

Labels
None yet
Projects
None yet
Milestone
v0.18.0
Development

No branches or pull requests
4 participants
@rhuss @mattmoor @navidshaikh @MIBc