Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty names in import #1547

Closed
kousu opened this issue Oct 3, 2023 · 1 comment
Closed

Allow empty names in import #1547

kousu opened this issue Oct 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kousu
Copy link

kousu commented Oct 3, 2023

Is your feature request related to a problem? Please describe.

I am often bulk importing emails using /admin/subscribers/import (to workaround #1546) of pre-existing subscribers, and I wish I didn't have to fill in a name field, especially since I'm unchecking "Overwrite".

I end up using files like

email,name,attributes
a@example.com,"name","{}"
b@hotmail.com,"name","{}"
c@gmail.com,"name","{}"
d@gmail.com,"name","{}"

but why is this a legal file

email,name,attributes
a@example.com,"name",
b@hotmail.com,"name",
c@gmail.com,"name",
d@gmail.com,"name",

but this isn't?

email,name,attributes
a@example.com,,"{}"
b@hotmail.com,,"{}"
c@gmail.com,,"{}"
d@gmail.com,,"{}"

The latter causes

skipping line 1: a@example.com: Invalid name.
skipping line 2: b@hotmail.com: Invalid name.
skipping line 3: c@gmail.com: Invalid name.
skipping line 3: d@gmail.com: Invalid name.

Describe the solution you'd like

Allow empty names during import. If that's not okay, allow it at least when "overwrite" is unchecked.

@kousu kousu added the enhancement New feature or request label Oct 3, 2023
@knadh
Copy link
Owner

knadh commented Oct 9, 2023

Please see this: #967

@knadh knadh closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants