Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu icon incorrectly changing after failed .obj change #903

Closed
siorai opened this issue Mar 8, 2018 · 5 comments
Closed

Menu icon incorrectly changing after failed .obj change #903

siorai opened this issue Mar 8, 2018 · 5 comments
Labels
2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases Fix commited Not Regression
Milestone

Comments

@siorai
Copy link
Contributor

siorai commented Mar 8, 2018

Branch: 2.x
Commit b33d030
Environment: Win10, version 1803, OS Build 17112.1

image

Seems that when I select the Load icon, and attempt to load a .obj file, it fails ( since I don't have a slicer installed, that's to be expected ) however instead of continuing to display 'load' it switches to 'cancel' as if it's been loaded. Selecting the 'cancel' button also seems to perform the same functionality as if it were still the load button.

Steps to reproduce:

install via pip3 install -r requirements.txt
python3 pronterface.py
select load from main UI, load a *.obj file
observer change in load button change to 'cancel'

Can make available the 2 .obj files I've tried if needed.

@kliment kliment added the 2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases label Mar 8, 2018
@rockstorm101
Copy link
Collaborator

rockstorm101 commented Mar 8, 2018 via email

@rockstorm101 rockstorm101 added this to the Release 2.0.0 milestone Mar 20, 2018
@kliment
Copy link
Owner

kliment commented Mar 22, 2018

Should be fixed in 2.x now - can someone confirm?

@hroncok
Copy link
Collaborator

hroncok commented Mar 22, 2018

Loading a bogus file won't change the button to Cancel now.

Loading a good file does not change the button to Cancel either.

When is the button supposed to say Cancel?

@kliment
Copy link
Owner

kliment commented Mar 22, 2018

While a file is being sliced and loaded, until the first layer has been processed, so if your slicer is slow to process a huge file you can stop it.

@hroncok
Copy link
Collaborator

hroncok commented Mar 22, 2018

OK. That happens.

@hroncok hroncok closed this as completed Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases Fix commited Not Regression
Projects
None yet
Development

No branches or pull requests

4 participants