Windows still panics in some cases

[sophiajt]

Hi all,

Thanks for the fixes to, I think we managed to fix some of our Windows instability with this PR: #359

Unfortunately, users are still reporting very similar issues. I haven't been able to reproduce it, yet, but I wanted to file an issue in case you are able to reproduce: nushell/nushell#2440

Happy to help wherever we can.

[gwenn]

A backtrace would be helpful.

[sophiajt]

@gwenn - I'll ask and see if I can get a backtrace

[Lucretiel]

I've tracked down the specific issue to here:

rustyline/src/tty/windows.rs

Lines 514 to 516 in 32f87be

	let res = self.set_console_cursor_position(info.dwCursorPosition);
	if let Err(error::ReadlineError::Io(ref e)) = res {
	if e.kind() == ErrorKind::Other && e.raw_os_error() == Some(87) {

The problem is that, when running in a terminal that isn't cmd.exe (like Windows Terminal), set_console_cursor_position returns an error code 87, which matches ErrorKind::InvalidInput, not ErrorKind::Other. It appears that errno 87 is always InvalidInput (per https://github.com/rust-lang/rust/blob/master/library/std/src/sys/windows/mod.rs#L64), so I think this line needs to be changed. I'll submit a PR making the change.

[gwenn]

v6.3.0 released