Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump for zeroconf to 0.25.4 #2107

Closed
mikevlz opened this issue Mar 28, 2020 · 3 comments
Closed

Version bump for zeroconf to 0.25.4 #2107

mikevlz opened this issue Mar 28, 2020 · 3 comments

Comments

@mikevlz
Copy link
Contributor

mikevlz commented Mar 28, 2020

Versions

it's all about p4a and module version, other things do not matter.

Description

I tried to build a mobile application to work with zeroconf-enabled devices. I've got it almost working.
The problem with python-zeroconf is that it is too old. It has a recipe with zeroconf-0.17.4, while the most recent is 0.25.4. There is a problem with that old version - i get services(devices) discovered, but can not get any additional info except the service(device) name. Moreover, Android OS does nto resolve mdns host names, so I know, there is a device with some name, but can't get it's IP-address.

I said myself, that I'm lucky enough, and changed the version string and requirements in the recipe for zeroconf module, After that I've rebuilt my application and checked the result. With the new version everything works fine, I get all info about devices, that I need.
Newer version doesn't depend on "netifaces", but it depends on "ifaddr" and "typing".
Also it is NOT COMPATIBLE with python 2.7.

Please, have a look at this module. May be there should be an option to use the newer version with python3.5+, while keeping older version for compatibility with python 2.7

@AndreMiras
Copy link
Member

I think the compatibility with Python2 can go, it's not like we want to maintain it.
Pull requests for an updated recipe are welcome :)

@mikevlz
Copy link
Contributor Author

mikevlz commented Apr 3, 2020

Hello, Andre, wanted PRs? Here is one #2128 ;)

@mikevlz
Copy link
Contributor Author

mikevlz commented Apr 4, 2020

Since PR is merged, I think we can close this issue

@mikevlz mikevlz closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants