Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments on filter menu "Add filter" #3511

Closed
andre-hohmann opened this issue Apr 22, 2020 · 3 comments · Fixed by #5523
Closed

Adjustments on filter menu "Add filter" #3511

andre-hohmann opened this issue Apr 22, 2020 · 3 comments · Fixed by #5523
Assignees
Labels
improvement scheduled issues already planned/"ordered" for implementation search search, filter

Comments

@andre-hohmann
Copy link
Collaborator

andre-hohmann commented Apr 22, 2020

Problems

1 The menu "Add filter" is shown, when the "enter key" is used. That is confusing, when the "enter key" is used to start the search/filter, because the user does not know, what to do with that.
It is ok, when the filter is activated by the button on the right side of the filter-box.

2 Added filters cannot be deleted by the garbage can-icon.

2022-09-01 (@andre-hohmann): The deletion of filters works now

Solution

1 Deactivation the "Add filter"-menu by enter-key

2 Activation of the garbage can-icon to enable the deletion of added filters.

2022-09-01 (@andre-hohmann): The deletion of filters works now

@solth
Copy link
Member

solth commented May 15, 2021

2 Activation of the garbage can-icon to enable the deletion of added filters.

Fixed by #4349

@andre-hohmann
Copy link
Collaborator Author

Update;

Problem 1 is still present:

1 The menu "Add filter" is shown, when the "enter key" is used. That is confusing, when the "enter key" is used to start the search/filter, because the user does not know, what to do with that.
It is ok, when the filter is activated by the button on the right side of the filter-box.
Solution: Deactivation the "Add filter"-menu by enter-key

Problem 2:
The deleted filters are shown until the user logs off and in again. Adding a filter is also completed only after log off/log in.
I am sure that at least adding a filter has once worked correctly.

@solth
Copy link
Member

solth commented Sep 9, 2021

Problem 2:
The deleted filters are shown until the user logs off and in again. Adding a filter is also completed only after log off/log in.
I am sure that at least adding a filter has once worked correctly.

You are right. Actually both functions (adding and deleting filters) were applied immediatley, so I am not sure why this stopped working again. I will take a look at it and report my findings here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement scheduled issues already planned/"ordered" for implementation search search, filter
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants