Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the order of addons in the install instructions is wrong #470

Closed
kittauri opened this issue Feb 4, 2025 · 0 comments · Fixed by #471
Closed

the order of addons in the install instructions is wrong #470

kittauri opened this issue Feb 4, 2025 · 0 comments · Fixed by #471
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@kittauri
Copy link
Contributor

kittauri commented Feb 4, 2025

The order in the addons list is wrong. In the current state of the docs, the slider addon will override the additional slider settings in Volto Light Theme. A User wouldnt had the possibility to have a button in the slider block.

Code

"addons": [
  "@eeacms/volto-accordion-block",
  "@kitconcept/volto-button-block",
  "@kitconcept/volto-dsgvo-banner",
  "@kitconcept/volto-heading-block",
  "@kitconcept/volto-introduction-block",
  "@kitconcept/volto-highlight-block",
  "@kitconcept/volto-separator-block",
  "@kitconcept/volto-light-theme",
  "@kitconcept/volto-slider-block",    
  "your_policy_addon_here"
],

"@kitconcept/volto-light-theme" and "@kitconcept/volto-slider-block" should be swapped as stated in the text under the code block.

Text
Your policy add-on should be the last one, so that it overrides any previous ones. @kitconcept/volto-light-theme should be the second-last, placed immediately before your policy add-on.

@kittauri kittauri added bug Something isn't working documentation Improvements or additions to documentation labels Feb 4, 2025
@kittauri kittauri self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant