Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.3.0 broke python 3.8 support with invalid typehinting #205

Closed
SirStigs opened this issue Aug 19, 2024 · 3 comments
Closed

Version 3.3.0 broke python 3.8 support with invalid typehinting #205

SirStigs opened this issue Aug 19, 2024 · 3 comments

Comments

@SirStigs
Copy link

venv/lib/python3.8/site-packages/watchtower/__init__.py:216: in CloudWatchLogHandler
    log_group_tags: dict[str, str] = {},
E   TypeError: 'type' object is not subscriptable

Looks like missing a from __future__ import annotations from the top (the init.py used to use from Typing import....)

@faraggi
Copy link

faraggi commented Aug 20, 2024

FWIW, I'm also having this issue now. I temporarily pinned the version to 3.2.0 until a fix is available.

@ckz8780
Copy link

ckz8780 commented Aug 20, 2024

Same issue here, but weirdly I tried pinning to 3.2.0 yesterday and it didn't work. Today I pinned boto to 1.34.117 (my last known working version) and now my deploy is working again but watchtower is still 3.3.0 in my lockfile.

Python 3.8.12 fwiw

@kislyuk
Copy link
Owner

kislyuk commented Aug 21, 2024

Fixed in v3.3.1. Sorry about the hassle.

@kislyuk kislyuk closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants