Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent check on group prefix 'keymaker' #10

Closed
laroo opened this issue Oct 24, 2016 · 1 comment
Closed

Inconsistent check on group prefix 'keymaker' #10

laroo opened this issue Oct 24, 2016 · 1 comment

Comments

@laroo
Copy link

laroo commented Oct 24, 2016

The functions 'get_groups' and 'sync_groups' uses different prefixes: underscore and dash

  • 'get_groups()' checks on a group prefix that starts with 'keymaker_'
  • 'sync_groups()' checks on a group prefix that starts with 'keymaker-' and group path is '/keymaker/'

I currently have both groups included in Amazon IAM to workaround this issue

@kislyuk
Copy link
Owner

kislyuk commented Nov 9, 2016

Thank you for noticing this. I need an integration test for this but I haven't gotten to the point where I'm comfortable with giving it write access to IAM in the test suite. Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants