Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Convert all Kirby Components to standalone components #3799

Open
10 tasks
Fuzzy3 opened this issue Feb 20, 2025 · 0 comments
Open
10 tasks

[Enhancement] Convert all Kirby Components to standalone components #3799

Fuzzy3 opened this issue Feb 20, 2025 · 0 comments
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@Fuzzy3
Copy link
Collaborator

Fuzzy3 commented Feb 20, 2025

Describe the enhancement

The Kirby Design System should follow the recent convention from angular and convert all of its components to standalone components. This will provide much more flexibility since consumers may then be much more specific in what components they want to import rather than importing the huge all-in-one KirbyModule.

Describe the solution you'd like

Make all or most components in the KirbyModule standalone.

Have you considered any alternatives?

Do nothing now and wait until the components are converted to CustomElements.

Are there any additional context?

Might give a better workaround for the problem in this: #3742


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@Fuzzy3 Fuzzy3 added enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed 👶🏻 New For new issues before prioritisation and refinement labels Feb 20, 2025
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Feb 20, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💌 Inbox to 📙 Backlog in Kirby Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Status: 📙 Backlog
Development

No branches or pull requests

1 participant