Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Card - Expose options to control lighten/darken background and loudness level #2443

Closed
Tracked by #2431
jkaltoft opened this issue Aug 30, 2022 · 0 comments · Fixed by #2469
Closed
Tracked by #2431

Comments

@jkaltoft
Copy link
Collaborator

jkaltoft commented Aug 30, 2022

When using e.g. a clickable Card with a dark background color (or image) the hover and active states are very subtle - almost invisible, because the interaction state effect is making the state layer darker. Maybe even more this is because the loudness level is very low. Darker colors need more loudness for the effect to be visible.

The exact same interaction state layer styles are applied to both the dark green and the white cards:

Screen.Recording.2022-08-30.at.19.54.41.mov

Internally we can invert it to make the state layer lighter, e.g. on attention level 2 buttons.

We should expose that option externally, so users of Kirby can apply it to a clickable Card.

In addition, we should consider to let consumers set the loudness level. Increasing the loudness level could also solve this problem. In some cases this might be more desirable than making the card lighter on hover.

Increasing the loudness levels for hover and active:

Screen.Recording.2022-08-30.at.20.02.47.mov

Lightening the background (loudness level not changed):

Screen.Recording.2022-08-30.at.20.07.39.mov

Both lightening the background and increasing the loudness level:

Screen.Recording.2022-08-30.at.20.11.07.mov
@jkaltoft jkaltoft changed the title Card - Should we expose option (to Kirby consumers) to lighten background on hover? [Enhancement] Card - Expose option (to Kirby consumers) to control lighten/darken background on hover etc. Aug 30, 2022
@jkaltoft jkaltoft added NOT Tech refined Needs Tech kickoff - solution outlined and agreed 👶🏻 New For new issues before prioritisation and refinement 🧑‍🎨 Needs UX labels Aug 30, 2022
@jkaltoft jkaltoft added this to Kirby Aug 30, 2022
@jkaltoft jkaltoft added this to the Interaction States milestone Aug 30, 2022
@jkaltoft jkaltoft changed the title [Enhancement] Card - Expose option (to Kirby consumers) to control lighten/darken background on hover etc. [Enhancement] Card - Expose option to control lighten/darken background on hover etc. Aug 30, 2022
@jkaltoft jkaltoft changed the title [Enhancement] Card - Expose option to control lighten/darken background on hover etc. [Enhancement] Card - Expose options to control lighten/darken background and loudness level Aug 30, 2022
@alxzak alxzak moved this to 📙 Backlog in Kirby Sep 2, 2022
@jkaltoft jkaltoft moved this from 📙 Backlog to 💡 Shaping in Kirby Sep 5, 2022
@alxzak alxzak moved this from 💡 Shaping to 🚀 In Progress in Kirby Sep 7, 2022
@jkaltoft jkaltoft linked a pull request Sep 8, 2022 that will close this issue
7 tasks
@jkaltoft jkaltoft moved this from 🚀 In Progress to 🔎 Review pending in Kirby Sep 8, 2022
@jkaltoft jkaltoft moved this from 🔎 Review pending to ✅ Done in Kirby Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant