Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Menu icons in Kirby #2395

Closed
1 of 11 tasks
henrikvoetmand opened this issue Jul 13, 2022 · 2 comments · Fixed by #2409
Closed
1 of 11 tasks

[Enhancement] Menu icons in Kirby #2395

henrikvoetmand opened this issue Jul 13, 2022 · 2 comments · Fixed by #2409
Assignees
Labels

Comments

@henrikvoetmand
Copy link
Collaborator

henrikvoetmand commented Jul 13, 2022

Describe the enhancement

Some icons for the new left menu is not in Kirby icons - they should be added.

Describe the solution you'd like

Add the attached svg icons to Kirby icons

Have you considered any alternatives?

No

Are there any additional context?

car
car
coinstack
coinstack
contact
contact
recurring
recurring
salery
salary


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@henrikvoetmand henrikvoetmand added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Jul 13, 2022
@jkaltoft
Copy link
Collaborator

@henrikvoetmand Do you know the names of the icons? If so, could you add them to the description?

@jkaltoft jkaltoft added this to Kirby Jul 13, 2022
@jkaltoft
Copy link
Collaborator

@henrikvoetmand Shouldn't it say recurring instead of reaccurring?

@RasmusKjeldgaard RasmusKjeldgaard moved this to 🚀 In Progress in Kirby Aug 10, 2022
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Aug 10, 2022
@jkaltoft jkaltoft moved this from 🚀 In Progress to 👀 Review in progess in Kirby Aug 10, 2022
Repository owner moved this from 👀 Review in progess to ✅ Done in Kirby Aug 10, 2022
@jkaltoft jkaltoft added 🟢 Ready for release and removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants