Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dropdown with popover not scrollable on native #2204

Closed
5 of 7 tasks
RasmusKjeldgaard opened this issue Apr 28, 2022 · 0 comments · Fixed by #2205
Closed
5 of 7 tasks

[BUG] Dropdown with popover not scrollable on native #2204

RasmusKjeldgaard opened this issue Apr 28, 2022 · 0 comments · Fixed by #2205
Assignees
Labels

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Apr 28, 2022

Describe the bug

When the list of items within the dropdown should be scrollable, nothing happens if you try to scroll the list on a native device.
NB: this bug does not happen in an emulated device in browsers, only when running on a device.

Describe how to reproduce the bug

  1. Create a page like so, preferably scrollable to verify that scroll lock is actually happening:
<kirby-page title="Hello, world. This is Kirby" >
  <kirby-page-content>
    <kirby-dropdown
      [items]="['item 1', 'item 2', 'item 3', 'item 4', 'item 5', 'item 6', 'item 7', 'item 8', 'item 9', 'item 10', 'item 11', 'item 12', 'item 13', 'item 14', 'item 15', 'item 16', 'item 17']"
      [usePopover]="true">
    </kirby-dropdown>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque eget turpis vitae diam tincidunt imperdiet. Sed molestie cursus augue</p>
  
  </kirby-page-content>
</kirby-page>
  1. Try to scroll the dropdown to reveal more items
  2. See that it is not possible to scroll

Which Kirby version was used?

5.3.1

What was the expected behavior?

Dropdown should be scrollable, page should still not be scrollable until dropdown closes

Add any screenshots

Please complete the following information:

  • OS: Android, iOS

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@RasmusKjeldgaard RasmusKjeldgaard added bug NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Apr 28, 2022
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Apr 28, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this to 🚀 In Progress in Kirby Apr 28, 2022
@RasmusKjeldgaard RasmusKjeldgaard removed NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Apr 28, 2022
@jkaltoft jkaltoft moved this from 🚀 In Progress to 👀 Review in progess in Kirby Apr 28, 2022
Repository owner moved this from 👀 Review in progess to ✅ Done in Kirby Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant