Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Remove deprecated ModalConfig title #2060

Closed
Tracked by #2061
MadsBuchmann opened this issue Feb 22, 2022 · 0 comments
Closed
Tracked by #2061

[Housekeeping] Remove deprecated ModalConfig title #2060

MadsBuchmann opened this issue Feb 22, 2022 · 0 comments

Comments

@MadsBuchmann
Copy link
Contributor

MadsBuchmann commented Feb 22, 2022

Describe the housekeeping request

In #1141 which was merged in October 2020 the title field of the ModalConfig (libs/designsystem/src/lib/components/modal/modal-wrapper/config/modal-config.ts) interface was deprecated.

We should fully remove the field. Potentially as part of v6?

However it seems that the ModalWrapperComponent still relies on config.title to display the title for the Modal:

// libs/designsystem/src/lib/components/modal/modal-wrapper/modal-wrapper.component.html      
<ion-header (touchstart)="onHeaderTouchStart($event)">
  <ion-toolbar>
    <ion-title>{{ config.title }}</ion-title>  // <------ Interesting part
    <ion-buttons slot="start" *ngIf="config.flavor === 'drawer'">
      <ng-container *ngTemplateOutlet="closeButton; context: { icon: 'arrow-down' }"></ng-container>
    </ion-buttons>
    <ion-buttons slot="end" *ngIf="config.flavor === 'modal'">
      <ng-container *ngTemplateOutlet="closeButton; context: { icon: 'close' }"></ng-container>
    </ion-buttons>
    <ion-buttons slot="end" *ngIf="config.flavor === 'drawer' && config.drawerSupplementaryAction">
      <ng-container
        *ngTemplateOutlet="supplementaryButton; context: { btn: config.drawerSupplementaryAction }"
      ></ng-container>
    </ion-buttons>
  </ion-toolbar>
</ion-header>
[...]

We need to solve that somehow before fully removing it.

This issue blocks #843

The solution that should be made in #843 can not rely on the title being passed by config.title. Therefore this issue has to be solved before #843 can be solved.

@MadsBuchmann MadsBuchmann added NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement housekeeping labels Feb 22, 2022
@alxzak alxzak moved this to 📙 Backlog in Kirby Apr 1, 2022
@alxzak alxzak added this to the Remove deprecated IconSettings milestone Apr 1, 2022
@MadsBuchmann MadsBuchmann moved this from 📙 Backlog to 🚀 In Progress in Kirby Apr 4, 2022
@MadsBuchmann MadsBuchmann moved this from 🚀 In Progress to 🔎 Review pending in Kirby Apr 4, 2022
@MadsBuchmann MadsBuchmann self-assigned this Apr 4, 2022
@alxzak alxzak moved this from 🔎 Review pending to 👀 Review in progess in Kirby Apr 5, 2022
@jkaltoft jkaltoft moved this from 👀 Review in progess to 💤 Impeeded in Kirby Apr 22, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💤 Impeeded to 👀 Review in progess in Kirby Apr 26, 2022
Repository owner moved this from 👀 Review in progess to ✅ Done in Kirby Apr 28, 2022
@RasmusKjeldgaard RasmusKjeldgaard removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants