Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Investigate why clean-up in modal doesn't work as expected (outlet & portal) #1312

Closed
8 tasks
hafstad opened this issue Feb 15, 2021 · 2 comments
Closed
8 tasks

Comments

@hafstad
Copy link
Contributor

hafstad commented Feb 15, 2021

Describe the bug
Our clean-up doesn't work as expected for outlet modals combined with portals. We have done a "quick fix", but needs to investigate why the issue happens.

By some reason the clean-up function after second navigation (used from a portal) gets a reference to the embedded footer inside the component which is about to be activated and not the "old" footer which should be removed.

To Reproduce

  1. Go to http://localhost:4200/drb/micro/cards (make sure you have kirby v. 1.4.5 which doesn't include quickfix)
  2. Click on 'bestil kort'
  3. Choose a card, which opens a modal with an outlet
  4. Click 'forsæt' in modal footer
  5. Choose an account and click 'forsæt'
  6. See error (you will see two footers, the footer on top is the footer from the page before which should have been removed)

Kirby version

  • 1.4.5

Tasks:

  • Move issue from "Ready to do" -> "in progress" on our project board
  • Create Fix Branch
  • Create test reproducing the error
  • Fix
  • If relevant Update Examples and Showcase
  • Push commits to GitHub
  • Open a pull request (remember to add closes #issueno to the description) and ask @kirbydesign/kirby-guild for review
  • Merge to master and delete branch
@hafstad hafstad added bug NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels Feb 15, 2021
@hafstad hafstad removed the NOT Tech refined Needs Tech kickoff - solution outlined and agreed label Feb 15, 2021
@RasmusKjeldgaard RasmusKjeldgaard added critical and removed NOT Prioritized Issue not yet prioritized and added to a Milestone labels Apr 8, 2021
@flemcito flemcito changed the title [BUG] Investigate why clean-up in mordal doesn't work as expected (outlet & portal) [BUG] Investigate why clean-up in modal doesn't work as expected (outlet & portal) Apr 22, 2021
@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented May 27, 2021

@hafstad Is this still a problem, and if so, do we have a link/description of the quickfix?
Can you look at this sometime soon?

I removed critical label as a quickfix exists

@alxzak
Copy link
Collaborator

alxzak commented Aug 16, 2021

This issue will be closed due to backlog prioritization and pruning.
#1704 (comment)

@alxzak alxzak closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants