Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce retry policy to http requests #6

Closed
killy971 opened this issue Jan 1, 2015 · 1 comment
Closed

Introduce retry policy to http requests #6

killy971 opened this issue Jan 1, 2015 · 1 comment
Assignees
Milestone

Comments

@killy971
Copy link
Owner

killy971 commented Jan 1, 2015

In the current implementation, each http request is only tried once, with the connection and read timeouts each set to 1 minute.
When the http request fails, it is never retried and no result is returned.

This change will improve the resiliency by introducing a retry policy to each http call.
The https://github.com/Soostone/retry library will be used for the implementation.

Feature branch: retry-http-requests

@killy971 killy971 added this to the v0.4.0 milestone Jan 1, 2015
@killy971 killy971 self-assigned this Jan 1, 2015
@killy971
Copy link
Owner Author

killy971 commented Jan 4, 2015

This change actually only covered the GET request (wait_url), and not the initial POST request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant