-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage result response reading #5
Comments
The logic should be easy to implement in a similar to what was done to read and parse the page linked from coveralls response (See killy971/hpc-coveralls#21). |
I did a poor job of announcing this change. Thanks @guillaume-nargeot for recognizing this. |
No problem Steve! I've just fixed the problem, and will add retry logic later. |
Feature branch: https://github.com/guillaume-nargeot/codecov-haskell/tree/fix-coverage-response-reading |
Another change was required to fix the problem: using the |
The following change was introduced on codecov server side, apparently by codecov/codecov-python@2eab8f9: instead of containing the total coverage result as a value, the response to codecov initial post request now contains a url (
wait_url
element in the json content).Reading this url should return the coverage result in json format as in the example below:
Here is the code showing how codecov-python implements the functionality to wait and read the total coverage result.
The text was updated successfully, but these errors were encountered: