Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage result response reading #5

Closed
killy971 opened this issue Dec 28, 2014 · 5 comments
Closed

Fix coverage result response reading #5

killy971 opened this issue Dec 28, 2014 · 5 comments
Assignees
Labels
Milestone

Comments

@killy971
Copy link
Owner

The following change was introduced on codecov server side, apparently by codecov/codecov-python@2eab8f9: instead of containing the total coverage result as a value, the response to codecov initial post request now contains a url (wait_url element in the json content).
Reading this url should return the coverage result in json format as in the example below:

{"coverage": 42}

Here is the code showing how codecov-python implements the functionality to wait and read the total coverage result.

@killy971 killy971 self-assigned this Dec 28, 2014
@killy971
Copy link
Owner Author

The logic should be easy to implement in a similar to what was done to read and parse the page linked from coveralls response (See killy971/hpc-coveralls#21).

@killy971 killy971 added the bug label Dec 28, 2014
@killy971 killy971 added this to the v0.3.0 milestone Dec 28, 2014
@stevepeak
Copy link

I did a poor job of announcing this change. Thanks @guillaume-nargeot for recognizing this.

@killy971
Copy link
Owner Author

No problem Steve!

I've just fixed the problem, and will add retry logic later.

@killy971
Copy link
Owner Author

@killy971
Copy link
Owner Author

killy971 commented Jan 1, 2015

Another change was required to fix the problem: using the CurlFollowLocation option in order to follow the link returned by HTTP 301 responses.
This issue is now fixed as of 1c623d5

@killy971 killy971 changed the title Fix coverage response reading Fix coverage result reading Jan 5, 2015
@killy971 killy971 changed the title Fix coverage result reading Fix coverage result response reading Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants