Add github actions CI workflows #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids the linker problems that appear in the CI builds that build podio on the fly. For some reason in these builds the presence of these includes tricks the compiler to pull in a call to TVersionCheck which usually happens in libpodioRootIO, even though no functionality from there is used in these tests.
vvolkl
approved these changes
Jul 22, 2021
|
I just realized the status badges in the README have the wrong url to the actual badge. Would need to be fixed as well in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Should we keep the travis CI workflows for now and remove them later, or should we migrate to github actions fully in this PR?
The linking problems that the "on-the-fly podio build" has, can easily be fixed by removing the unnecessary includes in the tricktrack test (
#include "podio/ROOTReader.h"would need thepodio::podioRootIOtarget to link against).