From e7f12c91c9db7209a88ce9d40155553228aefe28 Mon Sep 17 00:00:00 2001 From: Anna Wen <54281166+annawen1@users.noreply.github.com> Date: Tue, 31 Jan 2023 12:27:54 -0500 Subject: [PATCH] fix(styles): downgrade sass version as there is an issue with @extend (#9973) ### Related Ticket(s) {{Provide url(s) to the related ticket(s) that this pull request addresses}} ### Description There seems to be an issue with `@extend` in the recent upgrade of `sass`. Downgrading `sass` version until there is fix ### Changelog **Changed** - downgrade sass back to `~1.40.0` **Removed** - band-aid fixes that should be resolved with the `sass` downgrade --- web-components/packages/carbon-web-components/package.json | 2 +- .../src/components/breadcrumb/breadcrumb.scss | 7 ------- .../carbon-web-components/src/components/modal/modal.scss | 4 ---- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/web-components/packages/carbon-web-components/package.json b/web-components/packages/carbon-web-components/package.json index 3dbb624bdf26..3a957bc83dd0 100644 --- a/web-components/packages/carbon-web-components/package.json +++ b/web-components/packages/carbon-web-components/package.json @@ -193,7 +193,7 @@ "rollup-plugin-multi-input": "^1.3.1", "rollup-plugin-terser": "^7.0.2", "rtlcss": "^3.0.0", - "sass": "~1.57.0", + "sass": "~1.40.0", "sass-loader": "^10.0.0", "strip-comments": "^1.0.0", "style-loader": "^2.0.0", diff --git a/web-components/packages/carbon-web-components/src/components/breadcrumb/breadcrumb.scss b/web-components/packages/carbon-web-components/src/components/breadcrumb/breadcrumb.scss index aeccbbcdff40..e459bf9e6a43 100644 --- a/web-components/packages/carbon-web-components/src/components/breadcrumb/breadcrumb.scss +++ b/web-components/packages/carbon-web-components/src/components/breadcrumb/breadcrumb.scss @@ -17,13 +17,6 @@ $css--plex: true !default; :host(#{$prefix}-breadcrumb-item) { @extend .#{$prefix}--breadcrumb-item; - - // TODO: see if we can remove this ::after section after v11 upgrade - &::after { - margin-left: $spacing-03; - color: $text-primary; - content: '/'; - } } :host(#{$prefix}-breadcrumb-overflow-menu) { diff --git a/web-components/packages/carbon-web-components/src/components/modal/modal.scss b/web-components/packages/carbon-web-components/src/components/modal/modal.scss index 3ac9e44dcf33..b42244a4a4fe 100644 --- a/web-components/packages/carbon-web-components/src/components/modal/modal.scss +++ b/web-components/packages/carbon-web-components/src/components/modal/modal.scss @@ -74,10 +74,6 @@ :host(#{$prefix}-modal[open]) { @extend .#{$prefix}--modal, .is-visible; - - // TODO: look into if following two lines are necessary after v11 upgrade - opacity: 1; - visibility: inherit; } :host(#{$prefix}-modal-header) {