Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

determine why appackager doesn't work with pipenv 2023.12.1 #5

Open
freddrake opened this issue Feb 26, 2024 · 5 comments
Open

determine why appackager doesn't work with pipenv 2023.12.1 #5

freddrake opened this issue Feb 26, 2024 · 5 comments

Comments

@freddrake
Copy link
Collaborator

Setting editable to false in the lock file doesn't seem to have any effect. Investigation needed.

@freddrake
Copy link
Collaborator Author

The most recent "good" version of pipenv is version 2023.7.23; the problem is introduced in version 2023.8.19.

This is a known issue in pipenv: pypa/pipenv#6054

One approach to working around this is to examine the constructed venv to identify any editable installs, remove them, and re-install using the pip from the venv without the editable flag.

@wyllys66
Copy link
Contributor

wyllys66 commented Mar 6, 2024

Im currently using version 2023.10.24. However, I'm also not using appackager at the moment, but this is good info to have.

@freddrake
Copy link
Collaborator Author

Im currently using version 2023.10.24. However, I'm also not using appackager at the moment, but this is good info to have.

If you're only using pipenv to build locally so you'll be using a copy of your application sources anyway, there's not a problem. It's only when you're using an appackager-constructed .deb that you care about this (or any other tool that expects non-editable installs).

@freddrake
Copy link
Collaborator Author

This issue also describes the problem: pypa/pipenv#6221

Just got bitten by this again; appackager should check the pipenv version against known-bad versions and report the incompatibility to the user.

@wyllys66
Copy link
Contributor

wyllys66 commented Jan 8, 2025

Thanks for the update. This hasn't bitten me lately, but I'll keep an eye on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants