Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] New UI/Theme #775

Closed
EpiclyDelicious opened this issue Jul 16, 2017 · 10 comments
Closed

[Feature] New UI/Theme #775

EpiclyDelicious opened this issue Jul 16, 2017 · 10 comments

Comments

@EpiclyDelicious
Copy link

A new UI or theme for this application would just be wonderful. I obviously know it is more than likely not high on the priority list whatsoever, but... sadly a non-modern UI is what drives me away. Someone posted a UI/theme that looked amazing for KeePass' style applications on a forum. Sadly I cannot find the post, as I would give credit where it is due. It is also the same forum post I found out about KeeWeb.

dvqwh6v

I've been using KeePass 2 for awhile now, but tried switching to LastPass/Dashlane. Too many issues with both of those that I found. I even tried KeeWeb, but the UI just doesn't settle well with me.

The current UI/theme feels outdated still (no offense, the work you do is still great!). Customization is a huge part of KeePass' ecosystem with plugins.

Hopefully you consider this type of idea. 👍

@phoerious
Copy link
Member

The theme looks nice. But (almost) native platform integration has always been one of KeePassX(C)'s core features. There are lots of areas where we can improve things, but overall, the looks are not necessarily "dated". They are rather what applications on that platform look like. I understand that in times of web and mobile applications and Material design, people are getting used to different looks. But KeePassXC is a pure desktop application and should therefore integrate into the user's desktop. An application like the mockup above doesn't integrate into any platform.

@EpiclyDelicious
Copy link
Author

Yea, I realize after creating this I should of addressed more so about the native platform integration. Obviously this limits the amount of code you have to write and doesn't over-complicate things. Which is great, don't get me wrong!

It definitely is about modern day use of web/mobile apps including Material style design and the like. I don't think KeePassXC looks 'dated' necessarily, so I sort of retract that statement. I think maybe it's more of the icons. They're a lot more Windows 7/Windows XP style in my opinion. I actually prefer KeePass 2's icons more so because they're smaller and 'flows' better I suppose.

The feature more or less that I would be requesting is a way to 'choose' if it could look like that, if possible. I'm not saying you're wrong or anything here, but your statement "they are rather what applications on that platform look like" can't really be the case for something like Windows 8/8.1/10. Nothing about the application says 'this is a Windows application to me' except if I was running Windows 7 or XP.

Again, I appreciate the work you guys put into this to provide more support for Linux/Mac/Windows compatibility. I'm just at a tug-of-war between functionality and aesthetics.

@phoerious
Copy link
Member

Concerning the icon theme, there is already a discussion here: #756

@gagarine
Copy link

This one shouldn't be closed has a "wontfix"? I 100% agree their is multiple issue with the UX (icon, not field not perfectly aligned or to long/short) but it's not about a theme.

Say that, Qt application can have theme, but I think focusing on good default is better than giving the ability to change theme like in calibre.

@phoerious
Copy link
Member

Can you post a screen shot where things are not perfectly aligned? We paid very close attention to that.

@gagarine
Copy link

gagarine commented Aug 15, 2017

Ok "perfectly aligned" is not the biggest problem I think (but still there is a problem with the alignment). What I mean is the alignment/grid is not visually pleasing ;).

I quickly did some screenshot as an example of misalignment. But I can take a bit longer to try to spot them all when I got some spare time. Also, sometimes can be aligned on pixels... but when you look at it, it doesn't feel aligned. This is what append with the login screen on the right.

screen shot 2017-08-15 at 22 03 14

screen shot 2017-08-15 at 22 02 38

screen shot 2017-08-15 at 22 03 26

screen shot 2017-08-15 at 22 02 05

@phoerious
Copy link
Member

phoerious commented Aug 15, 2017

That is a Qt macOS bug (see https://bugreports.qt.io/browse/QTBUG-42457). We tried to mitigate it as much as possible, but we can't get it perfectly right without either screwing the layout completely on all other platforms or adding a stupid amount of layout workaround code only for macOS.

@gagarine
Copy link

I understand. I think also than changing icon will make the app look way more modern than trying to fix minor misalignment on OSX... specially with hacks.

@phoerious
Copy link
Member

We can try to optimize alignments a little further, but there isn't much room for improvement without an upstream fix. KeePassXC already looks a lot better on macOS than KeePassX did, but it's still a little rough around the edges compared to other platforms.

@droidmonkey
Copy link
Member

Most of this has been implemented in 2.3.0, closing in favor of a more specific suggestion in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants