Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: KeePassHTTP should return selected only credential #769

Closed
mauron85 opened this issue Jul 14, 2017 · 3 comments
Closed

Improvement: KeePassHTTP should return selected only credential #769

mauron85 opened this issue Jul 14, 2017 · 3 comments

Comments

@mauron85
Copy link

mauron85 commented Jul 14, 2017

User experience can be improved when KeePassHTTP return selected only credential instead of all possible.

Expected Behavior

Selected credential from HTTP Confirm Access Dialog should propagate also to the browser extensions.

Current Behavior

HTTP Confirm Access Dialog display all matched credentials as a list. List items are clickable, meaning user can select single credential entry.

image

Currently selecting credential in dialog has no effect.
As result user has to repeat same selection in the browser.

image

Possible Solution

Adding some sort of flag to http "get-logins" response, with information which entry was selected.
Then browser extension can read this information and only display selected entry or fill username/password immediately.

To stay compatible I suggest adding new prop IsSelected into http post response, indicating entry was selected in HTTP dialog.

{
"Count":4,
"Entries":[{
    "Login":"Y76RwRTD04meC/aItgadRQ==",
    "Name":"81q2E88dhKzWRuh7n7jiRiJmtKXSZByshrvVd+7jGII=",
    "Password":"Y76RwRTD04meC/aItgadRQ==",
    "StringFields":null,
    "Uuid":"9m1kgbJnzr33Nb84/ce70pI6k/yoeqnQOcSo2/OdQwwJgBf1tOS3BdBMxAMsGF1l"
    "IsSelected": true
}]
...
}
@droidmonkey
Copy link
Member

That dialog is just authorizing the transfer of the credentials from the database to the plug-in. The plugin takes it from there. This may still be an issue of providing all the suggested credentials instead of just the selected one though.

@mauron85
Copy link
Author

mauron85 commented Jul 14, 2017

A consider it more like UX problem then technical one. Even tough filtering which credentials will be passed to the browser directly in the dialog would be nice, I'll be more then happy with just information which username/password combo was selected in dialog. There is another option - make list in dialog not clickable to prevent confusion, but I really vote for my suggestion ;-)

@CuredByLaughter
Copy link
Contributor

KeePassHTTP was removed. As of 2.4.0 it is no longer part of KeePassXC. See #1752.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants