Browser access confirmation dialog pops up on tab change

[droidmonkey]

Overview

This only happens while currently on a website that requires confirmation of credentials. When a new database tab is selected, the browser access confirmation dialog pops up, steals focus, and regardless of whether Allow or Deny is chosen KeePassXC minimizes.

Steps to Reproduce

1. Go to a website that requires credential access confirmation
2. Open multiple databases
3. Switch between database tabs

Expected Behavior

Merely switching database tabs will not re-trigger a credential access confirmation. This should only happen when the user refreshes the page, clicks "Reload" in the extension popup menu, or requests credentials from the KPXC icon on the page.

Actual Behavior

Access confirmation is triggered every time.

Context

Occurs in 2.6.0-develop

[varjolintu]

Nice find!

[varjolintu]

Did you have search from all databases enabled?

[droidmonkey]

Yes I do

[varjolintu]

The problem here is that the browser extension detects the database change and requests the credentials again. I'm not sure that's something we want to prevent.

For me the access confirmation dialog stayed open when database was switched.

[droidmonkey]

If I am not interacting with the browser there is no reason for the browser service to repoll for credentials. That is a bug IMO.

The real crime in all this is that the application gets minimized when I dismiss the credential access dialog. That behavior should be removed entirely.

[varjolintu]

If I am not interacting with the browser there is no reason for the browser service to repoll for credentials. That is a bug IMO.

This would mean user will have to refresh the page every time database is switched, and the credentials are no longer retrieved automatically. The same kind of polling happens when your database is locked and you open it. (But I could try to make it so that switching doesn't trigger the retrieval, but unlock does)

The real crime in all this is that the application gets minimized when I dismiss the credential access dialog. That behavior should be removed entirely.

That's awful indeed.

EDIT: But then again, isn't this what we decided as a wanted behaviour? If the window was minimized, it's minimized again after the access dialog?