Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Implement OP_LESSTHANOREQUAL opcode #15

Closed
b-j-roberts opened this issue Jul 24, 2024 · 4 comments
Closed

[feat] Implement OP_LESSTHANOREQUAL opcode #15

b-j-roberts opened this issue Jul 24, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@b-j-roberts
Copy link
Contributor

Implement the OP_LESSTHANOREQUAL opcode using the opcodeLessThanOrEqual reference implementation from btcd

References

Guide on how to add an opcode in shinigami
@b-j-roberts b-j-roberts added enhancement New feature or request good first issue Good for newcomers labels Jul 24, 2024
@okhaimie-dev
Copy link
Contributor

@b-j-roberts I'll like to work on this next. Maybe, I'll wait on the other PR reviews first

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Jul 25, 2024

Hey @okhaimie-dev!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@okhaimie-dev
Copy link
Contributor

okhaimie-dev commented Jul 25, 2024 •
edited
Loading

@b-j-roberts I have addressed your suggestions in my other PRs
#12
#29

Can I get started on this?

@okhaimie-dev
Copy link
Contributor

okhaimie-dev commented Jul 25, 2024 •
edited
Loading

completed this, but waiting on this PR to merge
#32

i need an implement of at least OP_2 & OP_3 to finish my test

@okhaimie-dev okhaimie-dev mentioned this issue Jul 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@b-j-roberts @okhaimie-dev