Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract _run as much as possible #4290

Closed
merelcht opened this issue Nov 1, 2024 · 0 comments · Fixed by #4353
Closed

Abstract _run as much as possible #4290

merelcht opened this issue Nov 1, 2024 · 0 comments · Fixed by #4353

Comments

@merelcht
Copy link
Member

merelcht commented Nov 1, 2024

Description

The _run() method implementation in the various runners is very similar. We can refactor this to be even more similar so we can move all common code into the _run() in the AbstractRunner.

Context

This will make it easier for people to implement a custom runner, because the _run() method will have more in place to get started from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant