Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputs is not correctly set when its name contains a full stop #1522

Closed
1 task done
PetitLepton opened this issue Sep 7, 2023 · 2 comments
Closed
1 task done

outputs is not correctly set when its name contains a full stop #1522

PetitLepton opened this issue Sep 7, 2023 · 2 comments
Assignees
Labels
Community Issue: Bug Report Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do

Comments

@PetitLepton
Copy link

Description

When the output of a node contains a full stop, for example my.dataset, the visualization breaks by having the wrong name for the data set, in the example my, and the data set is not linked to the node.

Context

Creating a simple pipeline.

Steps to Reproduce

Create a pipeline whose single node is

from kedro.pipeline import Pipeline, pipeline, node


def create_pipeline(**kwargs) -> Pipeline:
    return Pipeline([node(lambda s: s, inputs="first", outputs="first.out")])

Expected Result

One should have seen first.out as the output data set of the node.

Actual Result

Screenshot from 2023-09-07 13-26-09

Your Environment

Include as many relevant details as possible about the environment you experienced the bug in:

  • Web browser system and version:
  • Operating system and version: Ubutnu 22.04
  • NodeJS version used (if relevant):
  • Kedro version used (if relevant): 18.12
  • Python version used (if relevant): 3.10.10

Checklist

  • Include labels so that we can categorise your issue
@tynandebold tynandebold added Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do labels Sep 13, 2023
@MehdiNV MehdiNV self-assigned this Sep 14, 2023
@noklam
Copy link
Contributor

noklam commented Sep 25, 2023

@PetitLepton In Kedro, . has a special meaning and indicate namespace pipeline which is why it is disconnected in viz, because the input is not namespaced but the output is. (as you can see, viz think that there is a "First" namespace pipeline)) https://docs.kedro.org/en/stable/tutorial/add_another_pipeline.html

As an alternative you may name your output as first_output.

@tynandebold
Copy link
Member

Closing this now. Thanks, @noklam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue: Bug Report Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do
Projects
None yet
Development

No branches or pull requests

4 participants