Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Link stop working #103

Closed
kdcllc opened this issue Jan 22, 2020 · 2 comments · Fixed by #106
Closed

Source Link stop working #103

kdcllc opened this issue Jan 22, 2020 · 2 comments · Fixed by #106
Labels
3.0 .NET Core Version bug Something isn't working

Comments

@kdcllc
Copy link
Owner

kdcllc commented Jan 22, 2020

According to the following discussions:

The following must be updated in settings.props file:

<PropertyGroup>
  <DebugSymbols>True</DebugSymbols>
  <DebugType>Embedded</DebugType>
  <EmbedAllSources>True</EmbedAllSources>
</PropertyGroup>
@kdcllc kdcllc added 3.0 .NET Core Version bug Something isn't working labels Jan 22, 2020
kdcllc added a commit that referenced this issue Jan 22, 2020
kdcllc added a commit that referenced this issue Jan 22, 2020
@mikebeaton
Copy link

mikebeaton commented Jan 23, 2020

You don't need DebugSymbols here, since it is overridden by DebugType.

You might want to be aware that those settings are not recommended for public packages, because it noticeably increases the size of the .nupkg and therefore download and restore times, by including debugging info and source files that only a few people will want or use. The better alternative for public repos is to use a separate .snupkg file (it which case you could use either SourceLink, which will work there, or no SourceLink and EmbedAllSources instead). For private or small audience size repos, the settings you've mentioned are fine and much easier to set up and use.

@kdcllc
Copy link
Owner Author

kdcllc commented Jan 23, 2020

@mikebeaton thanks for the explanation of these changes. The documentation is definitely is lacking. I am looking into redoing the deployment process altogether with publishing to NuGet symbol server.

<DebugType>portable</DebugType>
dotnet pack  Bet.AspNetCore.sln -p:configuration=Release -p:Version=2.1.0 -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg -o Packages -p:DebugType=portable

nuget push *.snupkg -Source https://api.nuget.org/v3/index.json

kdcllc added a commit that referenced this issue Jan 23, 2020
@kdcllc kdcllc closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 .NET Core Version bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants