Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid CRD creation of kcp.dev groups outside of system:system-crds #772

Closed
sttts opened this issue Mar 25, 2022 · 5 comments · Fixed by #1006
Closed

Forbid CRD creation of kcp.dev groups outside of system:system-crds #772

sttts opened this issue Mar 25, 2022 · 5 comments · Fixed by #1006
Assignees
@robinbobbitt
Labels
area/server Everything around `kcp start` good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. severity/timebomb Something that we must fix before production
Milestone
v0.5.0

Comments

@sttts
Copy link
Member

sttts commented Mar 25, 2022

*.kcp.dev CRDs should be reserved for the system, i.e. a user should not be able to install these outside of the shadow workspace system:system-crds (compare #755 where it was introduced to host the kcp CRDs). This issue is about adding an admission plugin to stop *.kcp.dev CRD creation in any other workspace.
@sttts sttts added kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. area/server Everything around `kcp start` severity/timebomb Something that we must fix before production labels Mar 25, 2022
@sttts sttts modified the milestones: p4, Prototype 4 Mar 25, 2022
@sttts
Copy link
Member Author

sttts commented Mar 25, 2022

Note: without this, it's easy to brick kcp by creating a kcp.dev CRD of different schema.

@pradeepnnv
Copy link
Contributor

I would like to try this.

@ncdc ncdc modified the milestones: v0.4.0, TBD Apr 27, 2022
@sttts
Copy link
Member Author

sttts commented May 4, 2022

@pradeepnnv are you still interested? Do you need some pointers? Feel free to start a thread in Slack. We can talk.

@sttts sttts mentioned this issue May 4, 2022
Closed
@robinbobbitt
Copy link
Contributor

If @pradeepnnv isn't still interested, I can pick this one up.

@ncdc
Copy link
Member

ncdc commented May 6, 2022

@robinbobbitt thanks, please proceed. Hopefully we can find other issues for @pradeepnnv if still interested.

@robinbobbitt robinbobbitt mentioned this issue May 6, 2022
Merged
@ncdc ncdc modified the milestones: TBD, v0.5.0 May 9, 2022
@ncdc ncdc closed this as completed in #1006 May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinbobbitt robinbobbitt

Labels
area/server Everything around `kcp start` good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. severity/timebomb Something that we must fix before production
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Forbid kcp.dev CRD groups outside system:system-crds robinbobbitt/kcp
4 participants
@ncdc @sttts @robinbobbitt @pradeepnnv