Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User notes on the validity of two transformations #193

Open
SSL32081 opened this issue Mar 3, 2025 · 1 comment
Open

User notes on the validity of two transformations #193

SSL32081 opened this issue Mar 3, 2025 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@SSL32081
Copy link

SSL32081 commented Mar 3, 2025

The two transformations, DistanceToSNRWeightedDistanceTransform and GeocentricArrivalPhaseToDetectorArrivalPhaseTransform, are designed to reduce parameter degeneracies, followed from arXiv:2207.03508.
These transforms assume the waveform consists of only the dominant quadrupolar mode, which is implicitly used in the two scaling factors: _calc_R_dets and _calc_R_det_arg. However, this assumption is invalid for most of the state-of-the-art waveform approximants, e.g. IMRPhenomXPHM and NRSur7dq4, with includes harmonics up to $\ell \leqslant 4$.

This fact was also noted by the authors in Sec. IV B, quote:

The symmetries in Section IV A are only approximate, since the detectors are not perfectly aligned, and general waveform models have additional effects like orbital precession and higher harmonics that are not modeled by Eq. (7).

Therefore, the documentation should include a note for users to use at their discretion or even raise a warning in the RunManager if they are used in conjunction with incompatible waveforms.
This is also a chance to update the documentation to include a reference to that article.

@ThibeauWouters
Copy link
Collaborator

This is certainly good to note in the documentation although not so urgent for now as eg IMRPhenomXPHM is not yet supported in Jim

@thomasckng thomasckng added the documentation Improvements or additions to documentation label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants